Bug 203958 - Many resourceLoadStatistics tests and storageAccess tests using the ITP Database redirect to the corresponding memory store test after setting a cookie
Summary: Many resourceLoadStatistics tests and storageAccess tests using the ITP Datab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: katherine_cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-07 08:57 PST by katherine_cheney
Modified: 2019-11-07 15:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (24.49 KB, patch)
2019-11-07 09:47 PST, katherine_cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description katherine_cheney 2019-11-07 08:57:43 PST
Many resourceLoadStatistics tests and storageAccess tests using the ITP Database redirect to the corresponding memory store test after setting a cookie, as opposed to redirecting back to themselves. This went unnoticed because the test files are identical after the initialization of the store. I think its important to fix these instances to prevent future confusion over failures if any files redirected-to are removed or edited.
Comment 1 Radar WebKit Bug Importer 2019-11-07 08:59:04 PST
<rdar://problem/56984114>
Comment 2 katherine_cheney 2019-11-07 09:47:21 PST
Created attachment 383059 [details]
Patch
Comment 3 John Wilander 2019-11-07 14:15:11 PST
API tests on iOS "New failures: set([u'TestWebKitAPI.ServiceWorkers.ThrottleCrash'])" looks unrelated.
Comment 4 John Wilander 2019-11-07 14:18:30 PST
Comment on attachment 383059 [details]
Patch

Looks good! As discussed, we should come up with a way to make it simple to get it right, such as generating the redirect URL based on the test case's start URL or by generating the HTML file's name from a descriptive string such as "Request and grant access then detach should not have access" -> "request-and-grant-access-then-detach-should-not-have-access.html".
Comment 5 WebKit Commit Bot 2019-11-07 15:16:45 PST
Comment on attachment 383059 [details]
Patch

Clearing flags on attachment: 383059

Committed r252210: <https://trac.webkit.org/changeset/252210>
Comment 6 WebKit Commit Bot 2019-11-07 15:16:47 PST
All reviewed patches have been landed.  Closing bug.