Bug 203895 - Indentation in ThreadGlobalData.h is incorrect
Summary: Indentation in ThreadGlobalData.h is incorrect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks: 182686
  Show dependency tree / graph
 
Reported: 2019-11-06 05:19 PST by Chris Lord
Modified: 2019-11-07 01:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.72 KB, patch)
2019-11-06 05:24 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-highsierra (3.46 MB, application/zip)
2019-11-06 10:10 PST, WebKit Commit Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2019-11-06 05:19:07 PST 
Currently, if you want to make a change to ThreadGlobalData.h, the style checker will likely complain, as the indentation in this file is incorrect. Either your change will look wrong or you'll need to re-indent the file. Filing this bug to do the latter without any unrelated changes.
Comment 1 Chris Lord 2019-11-06 05:24:06 PST 
Created attachment 382920 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-06 10:10:27 PST 
Comment on attachment 382920 [details]
Patch

Rejecting attachment 382920 [details] from commit-queue.

New failing tests:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Full output: https://webkit-queues.webkit.org/results/13219394
Comment 3 WebKit Commit Bot 2019-11-06 10:10:29 PST 
Created attachment 382937 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 Adrian Perez 2019-11-07 01:09:34 PST 
Comment on attachment 382920 [details]
Patch

Setting cq+, indentation changes are unrelated to the EWS failures.
Comment 5 WebKit Commit Bot 2019-11-07 01:52:35 PST 
Comment on attachment 382920 [details]
Patch

Clearing flags on attachment: 382920

Committed r252179: <https://trac.webkit.org/changeset/252179>
Comment 6 WebKit Commit Bot 2019-11-07 01:52:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-07 01:53:40 PST 
<rdar://problem/56976363>