Bug 203882 – WindowEventLoop should be shared among similar origin documents

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Share WindowEventLoop amongst similar-origin window events as HTML5 spec says:
https://html.spec.whatwg.org/multipage/webappapis.html#window-event-loop

[Ryosuke Niwa]

Created attachment 382902 [details]
WIP

[Radar WebKit Bug Importer]

<rdar://problem/56965038>

[Ryosuke Niwa]

Created attachment 382985 [details]
Patch

[Ryosuke Niwa]

Ping reviewers

[Wenson Hsieh]

Comment on attachment 382985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382985&action=review

> Source/WebCore/dom/WindowEventLoop.cpp:58
> +    ASSERT(windowEventLoopMap().contains(m_domain));

Do we need both this debug assert and the release assert below?

> LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html:22
> +    setTimeout(() => finishJSTest(), 3000);

I don’t think you meant to include this.

[Ryosuke Niwa]

(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 382985 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382985&action=review
> 
> > Source/WebCore/dom/WindowEventLoop.cpp:58
> > +    ASSERT(windowEventLoopMap().contains(m_domain));
> 
> Do we need both this debug assert and the release assert below?
> 
> > LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html:22
> > +    setTimeout(() => finishJSTest(), 3000);
> 
> I don’t think you meant to include this.

Oops these are added for debugging. Removed both.

[Ryosuke Niwa]

Committed r252221: <https://trac.webkit.org/changeset/252221>