WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
203882
WindowEventLoop should be shared among similar origin documents
https://bugs.webkit.org/show_bug.cgi?id=203882
Summary
WindowEventLoop should be shared among similar origin documents
Ryosuke Niwa
Reported
2019-11-06 01:02:53 PST
Share WindowEventLoop amongst similar-origin window events as HTML5 spec says:
https://html.spec.whatwg.org/multipage/webappapis.html#window-event-loop
Attachments
WIP
(12.26 KB, patch)
2019-11-06 01:07 PST
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Patch
(15.28 KB, patch)
2019-11-06 16:50 PST
,
Ryosuke Niwa
wenson_hsieh
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2019-11-06 01:07:16 PST
Created
attachment 382902
[details]
WIP
Radar WebKit Bug Importer
Comment 2
2019-11-06 16:46:38 PST
<
rdar://problem/56965038
>
Ryosuke Niwa
Comment 3
2019-11-06 16:50:25 PST
Created
attachment 382985
[details]
Patch
Ryosuke Niwa
Comment 4
2019-11-07 12:07:03 PST
Ping reviewers
Wenson Hsieh
Comment 5
2019-11-07 12:17:41 PST
Comment on
attachment 382985
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=382985&action=review
> Source/WebCore/dom/WindowEventLoop.cpp:58 > + ASSERT(windowEventLoopMap().contains(m_domain));
Do we need both this debug assert and the release assert below?
> LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html:22 > + setTimeout(() => finishJSTest(), 3000);
I don’t think you meant to include this.
Ryosuke Niwa
Comment 6
2019-11-07 16:30:23 PST
(In reply to Wenson Hsieh from
comment #5
)
> Comment on
attachment 382985
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=382985&action=review
> > > Source/WebCore/dom/WindowEventLoop.cpp:58 > > + ASSERT(windowEventLoopMap().contains(m_domain)); > > Do we need both this debug assert and the release assert below? > > > LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html:22 > > + setTimeout(() => finishJSTest(), 3000); > > I don’t think you meant to include this.
Oops these are added for debugging. Removed both.
Ryosuke Niwa
Comment 7
2019-11-07 17:13:21 PST
Committed
r252221
: <
https://trac.webkit.org/changeset/252221
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug