Bug 20388 - <video> elements on Windows never becomes visible when a page is restored from the cache.
Summary: <video> elements on Windows never becomes visible when a page is restored fro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-14 17:44 PDT by Eric Carlson
Modified: 2008-08-14 17:53 PDT (History)
0 users

See Also:

Attachments
proposed patch (1.94 KB, patch)
2008-08-14 17:47 PDT, Eric Carlson 		adele: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2008-08-14 17:44:49 PDT 
<video> elements on Windows do not becomes visible when a page is restored from the cache, possibly as a is a side effect of the fix for rdar://6112219. 

This happens because the call sequence when restoring from the cache is such that m_qtMovie is NULL the first time the renderer calls MediaPlayer::setRect, but it caches the rect so MediaPlayerPrivate::setRect is never called when the renderer sets the size again after the movie is allocated.
Comment 1 Eric Carlson 2008-08-14 17:47:27 PDT 
Created attachment 22804 [details]
proposed patch
Comment 2 Adele Peterson 2008-08-14 17:53:49 PDT 
Committed revision 35772.