Bug 203879 - [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport
Summary: [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCore...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-05 21:53 PST by Fujii Hironori
Modified: 2019-11-06 18:06 PST (History)
11 users (show)

See Also:

Attachments
Patch (2.35 KB, patch)
2019-11-05 22:01 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (2.35 KB, patch)
2019-11-06 06:44 PST, Fujii Hironori 		ross.kirsling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-11-05 21:53:35 PST 
[Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport

After r252086, WinCairo DumpRenderTree.exe and
WebKitTestRunner.exe can't start because they are linked with
WinCairoRequirements libs.
Comment 1 Fujii Hironori 2019-11-05 22:01:52 PST 
Created attachment 382895 [details]
Patch
Comment 2 Fujii Hironori 2019-11-06 06:44:04 PST 
Created attachment 382923 [details]
Patch
Comment 3 Ross Kirsling 2019-11-06 12:12:44 PST 
Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

> Tools/WebKitTestRunner/PlatformWin.cmake:-39
> -    WebKit

I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?
Comment 4 Fujii Hironori 2019-11-06 17:31:34 PST 
Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

>> Tools/WebKitTestRunner/PlatformWin.cmake:-39
>> -    WebKit
> 
> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?

Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW.
Comment 5 Fujii Hironori 2019-11-06 17:39:45 PST 
Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

>>> Tools/WebKitTestRunner/PlatformWin.cmake:-39
>>> -    WebKit
>> 
>> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?
> 
> Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW.

I misread your comment. WebKitTestRunnerLib_LIBRARIES includes WebKit.

CMakeLists.txt:

set(WebKitTestRunner_LIBRARIES
    WebKit::JavaScriptCore
    WebCoreTestSupport
    WebKit
)

PlatformWin.cmake:

set(WebKitTestRunnerLib_LIBRARIES
    ${WebKitTestRunner_LIBRARIES}
    Comsuppw
    Oleacc
)

list(APPEND WebKitTestRunner_LIBRARIES
    shlwapi
)
Comment 6 Fujii Hironori 2019-11-06 18:05:30 PST 
Committed r252165: <https://trac.webkit.org/changeset/252165>
Comment 7 Radar WebKit Bug Importer 2019-11-06 18:06:18 PST 
<rdar://problem/56967581>