Bug 203879 – [Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fujii Hironori]

[Win] DumpRenderTree.exe and WebKitTestRunner.exe shouldn't link with WebCoreTestSupport

After r252086, WinCairo DumpRenderTree.exe and
WebKitTestRunner.exe can't start because they are linked with
WinCairoRequirements libs.

[Fujii Hironori]

Created attachment 382895 [details]
Patch

[Fujii Hironori]

Created attachment 382923 [details]
Patch

[Ross Kirsling]

Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

> Tools/WebKitTestRunner/PlatformWin.cmake:-39
> -    WebKit

I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?

[Fujii Hironori]

Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

>> Tools/WebKitTestRunner/PlatformWin.cmake:-39
>> -    WebKit
> 
> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?

Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW.

[Fujii Hironori]

Comment on attachment 382923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382923&action=review

>>> Tools/WebKitTestRunner/PlatformWin.cmake:-39
>>> -    WebKit
>> 
>> I take it that this one doesn't need to be preserved in WebKitTestRunnerLib?
> 
> Nope. WebKitTestRunner.exe doesn't need to link with WebKit. It loads WebKitTestRunnerLib.dll by using LoadLibraryW.

I misread your comment. WebKitTestRunnerLib_LIBRARIES includes WebKit.

CMakeLists.txt:

set(WebKitTestRunner_LIBRARIES
    WebKit::JavaScriptCore
    WebCoreTestSupport
    WebKit
)

PlatformWin.cmake:

set(WebKitTestRunnerLib_LIBRARIES
    ${WebKitTestRunner_LIBRARIES}
    Comsuppw
    Oleacc
)

list(APPEND WebKitTestRunner_LIBRARIES
    shlwapi
)

[Fujii Hironori]

Committed r252165: <https://trac.webkit.org/changeset/252165>

[Radar WebKit Bug Importer]

<rdar://problem/56967581>