Bug 203844 - REGRESSION(r252031): layout tests fail to run in non apple ports after r252031
Summary: REGRESSION(r252031): layout tests fail to run in non apple ports after r252031
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2019-11-05 01:19 PST by Carlos Garcia Campos
Modified: 2019-11-05 15:00 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.33 KB, patch)
2019-11-05 01:24 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2019-11-05 12:26 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.49 KB, patch)
2019-11-05 14:33 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-11-05 01:19:27 PST 
20:52:27.333 67892 Checking build ...
20:52:27.333 67892 ImageDiff was not found at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/Release/ImageDiff
20:52:29.923 67892 "Tools/Scripts/build-imagediff --release --gtk" took 2.59s
20:52:29.923 67892 Failed to run "['Tools/Scripts/build-imagediff', '--release', '--gtk']" exit_code: 254 cwd: /home/slave/webkitgtk/gtk-linux-64-release-tests/build

sysctl: cannot stat /proc/sys/hw/activecpu: No such file or directory
Can't exec "xcodebuild": No such file or directory at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitdirs.pm line 1910.
20:52:29.923 67892 Build check failed
20:52:29.932 67892 Testing completed, Exit status: -1
Comment 1 Carlos Garcia Campos 2019-11-05 01:24:09 PST 
Created attachment 382812 [details]
Patch
Comment 2 WebKit Commit Bot 2019-11-05 04:38:53 PST 
Comment on attachment 382812 [details]
Patch

Clearing flags on attachment: 382812

Committed r252050: <https://trac.webkit.org/changeset/252050>
Comment 3 WebKit Commit Bot 2019-11-05 04:38:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-05 04:39:16 PST 
<rdar://problem/56900657>
Comment 5 Truitt Savell 2019-11-05 11:22:13 PST 
It looks like this patch https://trac.webkit.org/changeset/252050/webkit

broke windows testing:
https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/3869

Can this be looked at quickly?
Comment 6 Jonathan Bedard 2019-11-05 12:26:52 PST 
Reopening to attach new patch.
Comment 7 Jonathan Bedard 2019-11-05 12:26:53 PST 
Created attachment 382840 [details]
Patch
Comment 8 Jonathan Bedard 2019-11-05 12:30:16 PST 
Don't have a windows machine on hand, but the stack trace is pretty explicit.
Comment 9 Aakash Jain 2019-11-05 12:40:53 PST 
rs=me
Comment 10 Jonathan Bedard 2019-11-05 14:33:33 PST 
Created attachment 382851 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2019-11-05 15:00:04 PST 
Comment on attachment 382851 [details]
Patch for landing

Clearing flags on attachment: 382851

Committed r252087: <https://trac.webkit.org/changeset/252087>
Comment 12 WebKit Commit Bot 2019-11-05 15:00:06 PST 
All reviewed patches have been landed.  Closing bug.