RESOLVED FIXED 203844
REGRESSION(r252031): layout tests fail to run in non apple ports after r252031 
https://bugs.webkit.org/show_bug.cgi?id=203844
Summary REGRESSION(r252031): layout tests fail to run in non apple ports after r252031
Carlos Garcia Campos
Reported 2019-11-05 01:19:27 PST
20:52:27.333 67892 Checking build ... 20:52:27.333 67892 ImageDiff was not found at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/Release/ImageDiff 20:52:29.923 67892 "Tools/Scripts/build-imagediff --release --gtk" took 2.59s 20:52:29.923 67892 Failed to run "['Tools/Scripts/build-imagediff', '--release', '--gtk']" exit_code: 254 cwd: /home/slave/webkitgtk/gtk-linux-64-release-tests/build sysctl: cannot stat /proc/sys/hw/activecpu: No such file or directory Can't exec "xcodebuild": No such file or directory at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/webkitdirs.pm line 1910. 20:52:29.923 67892 Build check failed 20:52:29.932 67892 Testing completed, Exit status: -1
Attachments
Patch (4.33 KB, patch)
2019-11-05 01:24 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2019-11-05 12:26 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.49 KB, patch)
2019-11-05 14:33 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-11-05 01:24:09 PST
Created attachment 382812 [details] Patch
WebKit Commit Bot
Comment 2 2019-11-05 04:38:53 PST
Comment on attachment 382812 [details] Patch Clearing flags on attachment: 382812 Committed r252050: <https://trac.webkit.org/changeset/252050>
WebKit Commit Bot
Comment 3 2019-11-05 04:38:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-11-05 04:39:16 PST
<rdar://problem/56900657>
Truitt Savell
Comment 5 2019-11-05 11:22:13 PST
It looks like this patch https://trac.webkit.org/changeset/252050/webkit broke windows testing: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/3869 Can this be looked at quickly?
Jonathan Bedard
Comment 6 2019-11-05 12:26:52 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 7 2019-11-05 12:26:53 PST
Created attachment 382840 [details] Patch
Jonathan Bedard
Comment 8 2019-11-05 12:30:16 PST
Don't have a windows machine on hand, but the stack trace is pretty explicit.
Aakash Jain
Comment 9 2019-11-05 12:40:53 PST
rs=me
Jonathan Bedard
Comment 10 2019-11-05 14:33:33 PST
Created attachment 382851 [details] Patch for landing
WebKit Commit Bot
Comment 11 2019-11-05 15:00:04 PST
Comment on attachment 382851 [details] Patch for landing Clearing flags on attachment: 382851 Committed r252087: <https://trac.webkit.org/changeset/252087>
WebKit Commit Bot
Comment 12 2019-11-05 15:00:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.