Bug 203831 - [iOS] Add logging and telemetry to mach services believed to be unused
Summary: [iOS] Add logging and telemetry to mach services believed to be unused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-04 16:39 PST by Per Arne Vollan
Modified: 2019-11-05 14:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.44 KB, patch)
2019-11-04 16:44 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-11-04 16:39:13 PST 
The sandbox rules for mach services believed to be unused should have logging and telemetry added to confirm whether the assumption is correct.
Comment 1 Per Arne Vollan 2019-11-04 16:44:58 PST 
Created attachment 382789 [details]
Patch
Comment 2 Geoffrey Garen 2019-11-05 11:59:51 PST 
Comment on attachment 382789 [details]
Patch

r=me
Comment 3 Per Arne Vollan 2019-11-05 13:11:41 PST 
(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 382789 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2019-11-05 14:05:55 PST 
Comment on attachment 382789 [details]
Patch

Clearing flags on attachment: 382789

Committed r252081: <https://trac.webkit.org/changeset/252081>
Comment 5 WebKit Commit Bot 2019-11-05 14:05:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-05 14:06:16 PST 
<rdar://problem/56918131>
Comment 7 Brent Fulgham 2019-11-05 14:20:08 PST 
Comment on attachment 382789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382789&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-166
> -           (global-name "com.apple.coremedia.routingsessionmanager.xpc")

Make sure you test Airplay before deciding this can be removed.
Comment 8 Per Arne Vollan 2019-11-05 14:37:16 PST 
(In reply to Brent Fulgham from comment #7)
> Comment on attachment 382789 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382789&action=review
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-166
> > -           (global-name "com.apple.coremedia.routingsessionmanager.xpc")
> 
> Make sure you test Airplay before deciding this can be removed.

Ah, that's a good point, will do :)

Thanks for reviewing!