Bug 203828 – TestWebKitAPI.WebKit.DocumentEditingContext is failing on iPad

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

On iPad, TestWebKitAPI.WebKit.DocumentEditingContext fails with output like:

[[
/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:213
Expected equality of these values:
  23
  rects[0].CGRectValue.size.width
    Which is: 16


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:213
Expected equality of these values:
  24
  rects[0].CGRectValue.size.height
    Which is: 17


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:214
Expected equality of these values:
  23
  rects[1].CGRectValue.origin.x
    Which is: 16


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:214
Expected equality of these values:
  23
  rects[1].CGRectValue.size.width
    Which is: 16


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:214
Expected equality of these values:
  24
  rects[1].CGRectValue.size.height
    Which is: 17


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:215
Expected equality of these values:
  46
  rects[2].CGRectValue.origin.x
    Which is: 32


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:215
Expected equality of these values:
  23
  rects[2].CGRectValue.size.width
    Which is: 16


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:215
Expected equality of these values:
  24
  rects[2].CGRectValue.size.height
    Which is: 17


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:216
Expected equality of these values:
  69
  rects[3].CGRectValue.origin.x
    Which is: 48


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:216
Expected equality of these values:
  23
  rects[3].CGRectValue.size.width
    Which is: 16


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:216
Expected equality of these values:
  24
  rects[3].CGRectValue.size.height
    Which is: 17


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:224
Expected equality of these values:
  23
  rects.firstObject.CGRectValue.size.width
    Which is: 16


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:224
Expected equality of these values:
  24
  rects.firstObject.CGRectValue.size.height
    Which is: 17


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:227
Expected equality of these values:
  138
  rects.firstObject.CGRectValue.origin.x
    Which is: 96


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:227
Expected equality of these values:
  23
  rects.firstObject.CGRectValue.size.width
    Which is: 16


/Volumes/.../Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:227
Expected equality of these values:
  24
  rects.firstObject.CGRectValue.size.height
    Which is: 17
]]

[Daniel Bates]

<rdar://problem/55854631>

[Daniel Bates]

Created attachment 382781 [details]
Patch

This patch will fail to apply because it depends on patch for bug #203817.

[Daniel Bates]

EWS reports the test failed on iOS:

[[
    
    /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:209
    Expected equality of these values:
      CGRectMake(0, 0, glyphWidth, glyphWidth)
        Which is: (origin = (x = 0, y = 0), size = (width = 25, height = 25))
      rects[0].CGRectValue
        Which is: (origin = (x = 0, y = 0), size = (width = 30, height = 30))
    
    
    /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:210
    Expected equality of these values:
      CGRectMake(glyphWidth, 0, glyphWidth, glyphWidth)
        Which is: (origin = (x = 25, y = 0), size = (width = 25, height = 25))
      rects[1].CGRectValue
        Which is: (origin = (x = 30, y = 0), size = (width = 30, height = 30))
    
    
    /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:211
    Expected equality of these values:
      CGRectMake(2 * glyphWidth, 0, glyphWidth, glyphWidth)
        Which is: (origin = (x = 50, y = 0), size = (width = 25, height = 25))
      rects[2].CGRectValue
        Which is: (origin = (x = 60, y = 0), size = (width = 30, height = 30))
    
    
    /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:212
    Expected equality of these values:
      CGRectMake(3 * glyphWidth, 0, glyphWidth, glyphWidth)
        Which is: (origin = (x = 75, y = 0), size = (width = 25, height = 25))
      rects[3].CGRectValue
        Which is: (origin = (x = 90, y = 0), size = (width = 30, height = 30))
    
    
    /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:220
    Expected equality of these values:
      CGRectMake(0, 0, glyphWidth, glyphWidth)
        Which is: (origin = (x = 0, y = 0), size = (width = 25, height = 25))
      rects.firstObject.CGRectValue
        Which is: (origin = (x = 0, y = 0), size = (width = 30, height = 30))
    
    
    /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:223
    Expected equality of these values:
      CGRectMake(6 * glyphWidth, 0, glyphWidth, glyphWidth)
        Which is: (origin = (x = 150, y = 0), size = (width = 25, height = 25))
      rects.firstObject.CGRectValue
        Which is: (origin = (x = 180, y = 0), size = (width = 30, height = 30))
]]

Why is the width 30!?!? I asked for 25px square glyphs. Something is blowing up the rects...

[Daniel Bates]

It's the viewport. I was testing my patch with an iPad simulator. EWS uses the iPhone simulator.

[Daniel Bates]

If I put:

<meta name='viewport' content='initial-scale=2'>

Then the test passes in both iPad 9.7 and iPhone 8 simulators. I don't understand...

[Tim Horton]

(In reply to Daniel Bates from comment #5)
> If I put:
> 
> <meta name='viewport' content='initial-scale=2'>
> 
> Then the test passes in both iPad 9.7 and iPhone 8 simulators. I don't
> understand...

Is it text autosizing?

[Daniel Bates]

(In reply to Tim Horton from comment #6)
> (In reply to Daniel Bates from comment #5)
> > If I put:
> > 
> > <meta name='viewport' content='initial-scale=2'>
> > 
> > Then the test passes in both iPad 9.7 and iPhone 8 simulators. I don't
> > understand...
> 
> Is it text autosizing?

Yes

[Daniel Bates]

(In reply to Daniel Bates from comment #7)
> (In reply to Tim Horton from comment #6)
> > (In reply to Daniel Bates from comment #5)
> > > If I put:
> > > 
> > > <meta name='viewport' content='initial-scale=2'>
> > > 
> > > Then the test passes in both iPad 9.7 and iPhone 8 simulators. I don't
> > > understand...
> > 
> > Is it text autosizing?
> 
> Yes

Forgot...

[Daniel Bates]

Created attachment 382833 [details]
To Land

[Daniel Bates]

Comment on attachment 382833 [details]
To Land

Clearing flags on attachment: 382833

Committed r252061: <https://trac.webkit.org/changeset/252061>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.