Fix flaky tests in http/tests/cache/disk-cache
Created attachment 382764 [details] Patch
Created attachment 382803 [details] Patch
Comment on attachment 382803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382803&action=review > Source/WebKit/ChangeLog:8 > + Right now tests that set the cache model do so using a race condition. I think this will fix the flakyness we've observed. Is the plan to update TestExpectations at a later stage once the theory is validated? > Tools/WebKitTestRunner/TestInvocation.cpp:-552 > - WKContextSetCacheModel(TestController::singleton().context(), model); Should we try to remove WKContextSetCacheModel?
Comment on attachment 382803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382803&action=review >> Source/WebKit/ChangeLog:8 >> + Right now tests that set the cache model do so using a race condition. I think this will fix the flakyness we've observed. > > Is the plan to update TestExpectations at a later stage once the theory is validated? Yes. >> Tools/WebKitTestRunner/TestInvocation.cpp:-552 >> - WKContextSetCacheModel(TestController::singleton().context(), model); > > Should we try to remove WKContextSetCacheModel? Yes.
http://trac.webkit.org/r252259
<rdar://problem/57032451>