Bug 203822 - Fix flaky tests in http/tests/cache/disk-cache
Summary: Fix flaky tests in http/tests/cache/disk-cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-04 13:07 PST by Alex Christensen
Modified: 2019-11-08 13:27 PST (History)
5 users (show)

See Also:

Attachments
Patch (11.52 KB, patch)
2019-11-04 13:08 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (11.71 KB, patch)
2019-11-04 20:03 PST, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-11-04 13:07:05 PST 
Fix flaky tests in http/tests/cache/disk-cache
Comment 1 Alex Christensen 2019-11-04 13:08:49 PST 
Created attachment 382764 [details]
Patch
Comment 2 Alex Christensen 2019-11-04 20:03:59 PST 
Created attachment 382803 [details]
Patch
Comment 3 youenn fablet 2019-11-08 06:43:57 PST 
Comment on attachment 382803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382803&action=review

> Source/WebKit/ChangeLog:8
> +        Right now tests that set the cache model do so using a race condition.  I think this will fix the flakyness we've observed.

Is the plan to update TestExpectations at a later stage once the theory is validated?

> Tools/WebKitTestRunner/TestInvocation.cpp:-552
> -        WKContextSetCacheModel(TestController::singleton().context(), model);

Should we try to remove WKContextSetCacheModel?
Comment 4 Alex Christensen 2019-11-08 13:24:49 PST 
Comment on attachment 382803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382803&action=review

>> Source/WebKit/ChangeLog:8
>> +        Right now tests that set the cache model do so using a race condition.  I think this will fix the flakyness we've observed.
> 
> Is the plan to update TestExpectations at a later stage once the theory is validated?

Yes.

>> Tools/WebKitTestRunner/TestInvocation.cpp:-552
>> -        WKContextSetCacheModel(TestController::singleton().context(), model);
> 
> Should we try to remove WKContextSetCacheModel?

Yes.
Comment 5 Alex Christensen 2019-11-08 13:26:29 PST 
http://trac.webkit.org/r252259
Comment 6 Radar WebKit Bug Importer 2019-11-08 13:27:18 PST 
<rdar://problem/57032451>