Bug 203821 - REGRESSION (r248750): Drop-down menu for Walgreens 2FA unresponsive to touch
Summary: REGRESSION (r248750): Drop-down menu for Walgreens 2FA unresponsive to touch
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-04 12:54 PST by Wenson Hsieh
Modified: 2019-11-04 15:48 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.48 KB, patch)
2019-11-04 14:10 PST, Wenson Hsieh
zalan: review+
Details | Formatted Diff | Diff
Patch for landing (6.47 KB, patch)
2019-11-04 15:02 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-11-04 12:54:39 PST
<rdar://problem/56550488>
Comment 1 Wenson Hsieh 2019-11-04 14:10:44 PST
Created attachment 382772 [details]
Patch
Comment 2 zalan 2019-11-04 14:20:57 PST
Comment on attachment 382772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382772&action=review

> Source/WebCore/page/ios/ContentChangeObserver.h:74
> +    void didNotStartFixedObservationTimerAfterMouseMove();

I'd call it willNotProceedWithFixedObservationTimeWindow
Comment 3 Wenson Hsieh 2019-11-04 14:24:26 PST
Comment on attachment 382772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382772&action=review

>> Source/WebCore/page/ios/ContentChangeObserver.h:74
>> +    void didNotStartFixedObservationTimerAfterMouseMove();
> 
> I'd call it willNotProceedWithFixedObservationTimeWindow

Sounds good! Changed to willNotProceedWithFixedObservationTimeWindow() and WillNotProceedWithFixedObservationTimeWindow
Comment 4 Wenson Hsieh 2019-11-04 15:02:18 PST
Created attachment 382777 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-11-04 15:48:54 PST
Comment on attachment 382777 [details]
Patch for landing

Clearing flags on attachment: 382777

Committed r252022: <https://trac.webkit.org/changeset/252022>