Bug 203813 - http/tests/resourceLoadStatistics/cookie-deletion.html is timing out
Summary: http/tests/resourceLoadStatistics/cookie-deletion.html is timing out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-04 09:16 PST by Kate Cheney
Modified: 2019-11-20 17:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.68 KB, patch)
2019-11-04 09:28 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (10.21 KB, patch)
2019-11-18 15:32 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (6.29 KB, patch)
2019-11-20 11:35 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2019-11-04 09:16:23 PST 
http/tests/resourceLoadStatistics/cookie-deletion.html is timing out on macOS
Comment 1 Kate Cheney 2019-11-04 09:28:18 PST 
Created attachment 382745 [details]
Patch
Comment 2 Brady Eidson 2019-11-04 09:58:35 PST 
Comment on attachment 382745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382745&action=review

> LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion.html:8
> +<body onload="setTimeout(function () { start() }, 1000);">

This guarantees that this test will take a a full second to get started (1000ms timeout)

That's generally too slow for a test that doesn't truly need to take that long.

Is there a reason a 0-timeout doesn't work? Or at least much less than a second?
Comment 3 Kate Cheney 2019-11-18 15:32:00 PST 
Created attachment 383798 [details]
Patch
Comment 4 Alexey Proskuryakov 2019-11-18 16:14:57 PST 
Comment on attachment 383798 [details]
Patch

rs=me, please wait for more EWS to complete
Comment 5 WebKit Commit Bot 2019-11-19 08:28:26 PST 
Comment on attachment 383798 [details]
Patch

Clearing flags on attachment: 383798

Committed r252630: <https://trac.webkit.org/changeset/252630>
Comment 6 WebKit Commit Bot 2019-11-19 08:28:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-19 08:29:18 PST 
<rdar://problem/57322805>
Comment 8 Kate Cheney 2019-11-20 11:35:46 PST 
Reopening to attach new patch.
Comment 9 Kate Cheney 2019-11-20 11:35:47 PST 
Created attachment 383976 [details]
Patch
Comment 10 John Wilander 2019-11-20 11:52:21 PST 
Comment on attachment 383976 [details]
Patch

Yeah, let’s try this. If EWS is happy, so am I.
Comment 11 Kate Cheney 2019-11-20 16:23:44 PST 
Mac-debug-wk1 seems to have been re-running because of the same unrelated flaky tests for the last 4 hours.
Comment 12 WebKit Commit Bot 2019-11-20 17:09:29 PST 
Comment on attachment 383976 [details]
Patch

Clearing flags on attachment: 383976

Committed r252720: <https://trac.webkit.org/changeset/252720>
Comment 13 WebKit Commit Bot 2019-11-20 17:09:31 PST 
All reviewed patches have been landed.  Closing bug.