Bug 203803 - move CrashReporterClientSPI.h and parts of WKCrashReporter to WTF so it can be used in JavaScriptCore
Summary: move CrashReporterClientSPI.h and parts of WKCrashReporter to WTF so it can b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-04 02:08 PST by Tuomas Karkkainen
Modified: 2019-11-05 11:37 PST (History)
12 users (show)

See Also:

Attachments
proposed patch (16.00 KB, patch)
2019-11-04 03:40 PST, Tuomas Karkkainen 		no flags Details | Formatted Diff | Diff
updated patch to address style errors (16.08 KB, patch)
2019-11-04 03:50 PST, Tuomas Karkkainen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Karkkainen 2019-11-04 02:08:11 PST 
move CrashReporterClientSPI.h and parts of WKCrashReporter to WTF so it can be used in JavaScriptCore
Comment 1 Tuomas Karkkainen 2019-11-04 03:40:42 PST 
Created attachment 382730 [details]
proposed patch
Comment 2 Tuomas Karkkainen 2019-11-04 03:50:09 PST 
Created attachment 382731 [details]
updated patch to address style errors
Comment 3 Saam Barati 2019-11-05 11:16:57 PST 
Comment on attachment 382731 [details]
updated patch to address style errors

View in context: https://bugs.webkit.org/attachment.cgi?id=382731&action=review

r=me

> Source/WebKit/ChangeLog:3
> +        move CrashReporterClientSPI.h and parts of WKCrashReporter to WTF so it can be used in JavaScriptCore

is there another bug to make JavaScriptCore use it?
Comment 4 WebKit Commit Bot 2019-11-05 11:36:19 PST 
Comment on attachment 382731 [details]
updated patch to address style errors

Clearing flags on attachment: 382731

Committed r252065: <https://trac.webkit.org/changeset/252065>
Comment 5 WebKit Commit Bot 2019-11-05 11:36:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-05 11:37:18 PST 
<rdar://problem/56912401>