Bug 20379 - WebCore has too many graphics #ifdefs
Summary: WebCore has too many graphics #ifdefs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-13 23:05 PDT by Eric Seidel (no email)
Modified: 2008-08-14 16:20 PDT (History)
0 users

See Also:


Attachments
Clean up AffineTransform.h (5.10 KB, patch)
2008-08-13 23:07 PDT, Eric Seidel (no email)
sam: review+
Details | Formatted Diff | Diff
Clean up GlyphBuffer.h (2.41 KB, patch)
2008-08-13 23:07 PDT, Eric Seidel (no email)
ap: review+
Details | Formatted Diff | Diff
Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction (1.65 KB, patch)
2008-08-13 23:07 PDT, Eric Seidel (no email)
ap: review+
Details | Formatted Diff | Diff
Move us one step closer to cross-platform svg/graphics code (6.69 KB, patch)
2008-08-14 15:48 PDT, Eric Seidel (no email)
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-08-13 23:05:29 PDT
WebCore still has way too many graphics #ifdefs.  We have nice platform solutions, we just don't deploy them everywhere.  I've attached a few more rounds of cleanup patches.
Comment 1 Eric Seidel (no email) 2008-08-13 23:06:09 PDT
I will of course add ChangeLogs to each after review.  ChangeLogs + git rebase don't get along nicely. :(  And no resolve-ChangeLog does not count as a full solution.
Comment 2 Eric Seidel (no email) 2008-08-13 23:07:18 PDT
Created attachment 22785 [details]
Clean up AffineTransform.h

 WebCore/platform/graphics/AffineTransform.h        |   34 ++++---------------
 .../graphics/cairo/AffineTransformCairo.cpp        |    2 +-
 WebCore/platform/graphics/cg/AffineTransformCG.cpp |    8 ++--
 WebCore/platform/graphics/qt/AffineTransformQt.cpp |    2 +-
 WebCore/platform/graphics/wx/AffineTransformWx.cpp |    2 +-
 5 files changed, 14 insertions(+), 34 deletions(-)
Comment 3 Eric Seidel (no email) 2008-08-13 23:07:21 PDT
Created attachment 22786 [details]
Clean up GlyphBuffer.h

 WebCore/platform/graphics/GlyphBuffer.h |   45 ++++++++++++++++---------------
 1 files changed, 23 insertions(+), 22 deletions(-)
Comment 4 Eric Seidel (no email) 2008-08-13 23:07:23 PDT
Created attachment 22787 [details]
Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction

 WebCore/html/CanvasRenderingContext2D.cpp |    4 +---
 WebCore/html/CanvasStyle.cpp              |    1 -
 WebCore/html/HTMLCanvasElement.cpp        |    7 -------
 3 files changed, 1 insertions(+), 11 deletions(-)
Comment 5 Sam Weinig 2008-08-13 23:09:02 PDT
Comment on attachment 22785 [details]
Clean up AffineTransform.h

Needs a ChangeLog.
Comment 6 Alexey Proskuryakov 2008-08-13 23:58:14 PDT
Comment on attachment 22786 [details]
Clean up GlyphBuffer.h

r=me
Comment 7 Alexey Proskuryakov 2008-08-14 00:03:13 PDT
Comment on attachment 22787 [details]
Remove unneed includes from HTMLCanvas and use the Gradient platform abstraction

r=me
Comment 8 Eric Seidel (no email) 2008-08-14 15:48:40 PDT
Created attachment 22800 [details]
Move us one step closer to cross-platform svg/graphics code

 WebCore/WebCore.xcodeproj/project.pbxproj         |    3 --
 WebCore/html/CanvasStyle.cpp                      |    7 -----
 WebCore/platform/graphics/Color.cpp               |    7 +++++
 WebCore/platform/graphics/Color.h                 |    2 +-
 WebCore/svg/graphics/cg/CgSupport.cpp             |    7 +++--
 WebCore/svg/graphics/cg/SVGPaintServerSolidCg.cpp |   27 ++++++++++-----------
 6 files changed, 25 insertions(+), 28 deletions(-)
Comment 9 Beth Dakin 2008-08-14 16:07:49 PDT
Comment on attachment 22800 [details]
Move us one step closer to cross-platform svg/graphics code

r=me!