Bug 203787 - LLIntGenerator should not allocate temporaries in between variables
Summary: LLIntGenerator should not allocate temporaries in between variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-02 12:09 PDT by Tadeu Zagallo
Modified: 2019-11-03 20:11 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.01 KB, patch)
2019-11-02 12:30 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (7.01 KB, patch)
2019-11-03 19:29 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-11-02 12:09:57 PDT 
...
Comment 1 Tadeu Zagallo 2019-11-02 12:30:32 PDT 
Created attachment 382684 [details]
Patch
Comment 2 Tadeu Zagallo 2019-11-02 12:32:06 PDT 
<rdar://problem/56840003>
Comment 3 Yusuke Suzuki 2019-11-02 22:58:51 PDT 
Comment on attachment 382684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382684&action=review

r=me

> Source/JavaScriptCore/wasm/WasmValidate.cpp:178
> +    void finishedParsingLocals() { }

In WebCore, this type of callback is named as didFinishParsingLocals. Can you align it to this?
Comment 4 Tadeu Zagallo 2019-11-03 19:17:15 PST 
Comment on attachment 382684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382684&action=review

Thanks for the review!

>> Source/JavaScriptCore/wasm/WasmValidate.cpp:178
>> +    void finishedParsingLocals() { }
> 
> In WebCore, this type of callback is named as didFinishParsingLocals. Can you align it to this?

Sure, I'll update it before landing.
Comment 5 Tadeu Zagallo 2019-11-03 19:29:20 PST 
Created attachment 382714 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-11-03 20:11:50 PST 
Comment on attachment 382714 [details]
Patch for landing

Clearing flags on attachment: 382714

Committed r251978: <https://trac.webkit.org/changeset/251978>
Comment 7 WebKit Commit Bot 2019-11-03 20:11:52 PST 
All reviewed patches have been landed.  Closing bug.