Bug 203779 - [LFC][Verification] Forced line break display runs don't have TextContext
Summary: [LFC][Verification] Forced line break display runs don't have TextContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-02 06:08 PDT by zalan
Modified: 2019-11-03 15:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2019-11-02 06:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2019-11-02 06:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-02 06:08:45 PDT 
Since they are not text runs.
Comment 1 Radar WebKit Bug Importer 2019-11-02 06:09:03 PDT 
<rdar://problem/56839710>
Comment 2 zalan 2019-11-02 06:16:54 PDT 
Created attachment 382675 [details]
Patch
Comment 3 zalan 2019-11-02 06:18:14 PDT 
Created attachment 382676 [details]
Patch
Comment 4 Antti Koivisto 2019-11-03 01:10:59 PST 
Comment on attachment 382676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382676&action=review

> Source/WebCore/layout/Verification.cpp:127
>          && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight())
>          && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop())
>          && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom())

There is areEssentiallyEqual for LayoutRects that could be used here.
Comment 5 zalan 2019-11-03 14:56:10 PST 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 382676 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382676&action=review
> 
> > Source/WebCore/layout/Verification.cpp:127
> >          && areEssentiallyEqual(inlineTextBox.logicalRight(), inlineRun.logicalRight())
> >          && areEssentiallyEqual(inlineTextBox.logicalTop(), inlineRun.logicalTop())
> >          && areEssentiallyEqual(inlineTextBox.logicalBottom(), inlineRun.logicalBottom())
> 
> There is areEssentiallyEqual for LayoutRects that could be used here.

This local version of areEssentiallyEqual is a bit more relaxed than a generic areEssentiallyEqual function (the epsilon covers cases when a final geometry value goes through a handful of arithmetic conversions)
Comment 6 WebKit Commit Bot 2019-11-03 15:39:08 PST 
Comment on attachment 382676 [details]
Patch

Clearing flags on attachment: 382676

Committed r251977: <https://trac.webkit.org/changeset/251977>
Comment 7 WebKit Commit Bot 2019-11-03 15:39:10 PST 
All reviewed patches have been landed.  Closing bug.