Bug 203776 – "ValueError('too many values to unpack') raised:" on imported css-backgrounds tests

• Status: RESOLVED
• Resolution: INVALID
• Component: Tools / Tests

[Simon Fraser (smfr)]

After importing css/css-backgrounds WPT, I hit this error when trying to run the tests:

worker/2: ValueError('too many values to unpack') raised:                      
    File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/message_pool.py", line 268, in run
      worker.handle(message.name, message.src, *message.args)
    File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 290, in handle
      self._run_test(test_input, test_list_name)
    File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 311, in _run_test
      self._update_test_input(test_input)
    File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 297, in _update_test_input
      test_input.reference_files = self._port.reference_files(test_input.test_name, device_type=self._port.target_host(self._worker_number).device_type)
    File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 539, in reference_files
      result = self._get_reftest_list(test_name)
    File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 512, in _get_reftest_list
      self._reftest_list[dirname] = Port._parse_reftest_list(self._filesystem, dirname)
    File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 529, in _parse_reftest_list
      expectation_type, test_file, ref_file = split_line

split_line is:
[u'fails', u'==', u'tall--cover--nonpercent-width-nonpercent-height.html', u'ref-tall-lime256x512-aqua256x256.html']

and this comes from line 89 in css/cass-backgrounds/background-size/vector/reftest.list
which looks like:

# We smear the background image when scaling it in these two tests...
fails == tall--cover--nonpercent-width-nonpercent-height.html ref-tall-lime256x512-aqua256x256.html
fails == tall--cover--nonpercent-width-nonpercent-height-viewbox.html ref-tall-lime256x512-aqua256x256.html

We fail to handle lines with "fail" at the start.

[Simon Fraser (smfr)]

*** Bug 203785 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

Created attachment 382682 [details]
Patch

[Alexey Proskuryakov]

EWS is failing webkitpy tests.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #3)
> EWS is failing webkitpy tests.

My hunch is the tests aren't one of the two special cases, probably need to to edit them.

[Radar WebKit Bug Importer]

<rdar://problem/69332016>

[Sam Sneddon [:gsnedders]]

reftest.list support was removed in bug 203783