Bug 203772 – Port DOMCache / DOMCacheStorage to the HTML5 event loop

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Port DOMCache / DOMCacheStorage to the HTML5 event loop.

[Chris Dumez]

Created attachment 382656 [details]
Patch

[Chris Dumez]

I suspect a bug in the WorkerEventLoop somehow. The cache-storage.https.html is passing for window but failing for workers.

[Chris Dumez]

Created attachment 382683 [details]
Patch

[Chris Dumez]

Comment on attachment 382683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382683&action=review

> Source/WebCore/workers/WorkerEventLoop.cpp:-101
> -    for (auto& task : m_tasks)

Found the WorkerEventLoop bug.

[Sam Weinig]

Comment on attachment 382683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382683&action=review

> Source/WebCore/workers/WorkerEventLoop.cpp:101
> +    auto tasks = WTFMove(m_tasks);

I think the kosher way of doing this is to swap with an empty Vector<Task>. Otherwise, it leaves m_tasks in a bad (though currently kind of ok) state.

[Chris Dumez]

(In reply to Sam Weinig from comment #5)
> Comment on attachment 382683 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382683&action=review
> 
> > Source/WebCore/workers/WorkerEventLoop.cpp:101
> > +    auto tasks = WTFMove(m_tasks);
> 
> I think the kosher way of doing this is to swap with an empty Vector<Task>.
> Otherwise, it leaves m_tasks in a bad (though currently kind of ok) state.

We guarantee that our WebKit types are in OK state after moving. We even have our own Optional because of this. I don’t really mind swapping with an empty vector but it is less concise and not necessary with WebKit types. We use this pattern a lot in WebKit too, although I know not everybody likes it.

[Chris Dumez]

Created attachment 382687 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382687 [details]
Patch

Clearing flags on attachment: 382687

Committed r251968: <https://trac.webkit.org/changeset/251968>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56844994>