Bug 203771 - [WebAuthn] CtapAuthenticator::tryDowngrade should distinguish requestData().options
Summary: [WebAuthn] CtapAuthenticator::tryDowngrade should distinguish requestData().o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2019-11-01 16:26 PDT by Jiewen Tan
Modified: 2019-11-04 16:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.44 KB, patch)
2019-11-01 17:06 PDT, Jiewen Tan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch for landing (2.44 KB, patch)
2019-11-03 22:34 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-11-01 16:26:44 PDT 
CtapAuthenticator::tryDowngrade should distinguish requestData().options.
Comment 1 Radar WebKit Bug Importer 2019-11-01 16:42:16 PDT 
<rdar://problem/56832618>
Comment 2 Jiewen Tan 2019-11-01 17:06:53 PDT 
Created attachment 382657 [details]
Patch
Comment 3 Brent Fulgham 2019-11-01 17:28:00 PDT 
Comment on attachment 382657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review

> Source/WebKit/ChangeLog:14
> +        No tests given there is no way to spoof google.com in our test infrastructures.

It might be better to say, "... no way to simulate google.com in our test infrastructure."
Comment 4 Jiewen Tan 2019-11-01 17:37:51 PDT 
Comment on attachment 382657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382657&action=review

Thanks Brent for r+ this patch. Waiting EWS before landing.

>> Source/WebKit/ChangeLog:14
>> +        No tests given there is no way to spoof google.com in our test infrastructures.
> 
> It might be better to say, "... no way to simulate google.com in our test infrastructure."

Fixed.
Comment 5 Jiewen Tan 2019-11-03 22:34:00 PST 
Created attachment 382716 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-11-03 23:32:50 PST 
The commit-queue encountered the following flaky tests while processing attachment 382716 [details]:

imported/w3c/web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker.html bug 202003 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2019-11-03 23:33:35 PST 
Comment on attachment 382716 [details]
Patch for landing

Clearing flags on attachment: 382716

Committed r251979: <https://trac.webkit.org/changeset/251979>