WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
203770
Fix the defaults of the SVGFEConvolveMatrixElement properties
https://bugs.webkit.org/show_bug.cgi?id=203770
Summary
Fix the defaults of the SVGFEConvolveMatrixElement properties
Said Abou-Hallawa
Reported
Saturday, November 2, 2019 12:01:54 AM UTC
Created
attachment 382642
[details]
test case Open the attached test case. Expected results: Default value for feConvolveMatrix divisor property is: 1 Default value for feConvolveMatrix orderX property is: 3 Default value for feConvolveMatrix orderY property is: 3 The specs links are:
https://www.w3.org/TR/SVG11/filters.html#feConvolveMatrixElementDivisorAttribute
https://www.w3.org/TR/SVG11/filters.html#feConvolveMatrixElementOrderAttribute
Attachments
test case
(704 bytes, image/svg+xml)
2019-11-01 16:01 PDT
,
Said Abou-Hallawa
no flags
Details
Patch
(19.15 KB, patch)
2019-11-01 16:14 PDT
,
Said Abou-Hallawa
sabouhallawa
: review?
Details
Formatted Diff
Diff
Safari 15.5 differs from other browsers
(623.60 KB, image/png)
2022-05-31 13:53 PDT
,
Ahmad Saleem
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
Saturday, November 2, 2019 12:14:57 AM UTC
Created
attachment 382647
[details]
Patch
Simon Fraser (smfr)
Comment 2
Thursday, November 14, 2019 12:30:36 AM UTC
Comment on
attachment 382647
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=382647&action=review
> Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:74 > + if (parseNumberOptionalNumber(value, x, y) && (x < 1 || y < 1)) > document().accessSVGExtensions().reportWarning("feConvolveMatrix: problem parsing order=\"" + value + "\". Filtered element will not be displayed."); > + m_orderX->setBaseValInternal(x); > + m_orderY->setBaseValInternal(y);
So we parse the values but set them anyway? Seems odd.
> Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:121 > + if (parseNumberOptionalNumber(value, x, y) && (x <= 0 || y <= 0)) > document().accessSVGExtensions().reportWarning("feConvolveMatrix: problem parsing kernelUnitLength=\"" + value + "\". Filtered element will not be displayed."); > + > + m_kernelUnitLengthX->setBaseValInternal(x); > + m_kernelUnitLengthY->setBaseValInternal(y);
Ditto.
Ahmad Saleem
Comment 3
Tuesday, May 31, 2022 9:53:19 PM UTC
Created
attachment 459904
[details]
Safari 15.5 differs from other browsers This issue is still present and reproducible in Safari 15.5 on macOS 12.4 while Chrome Canary 104 matches with Firefox Nightly 103. Thanks!
Radar WebKit Bug Importer
Comment 4
Thursday, February 8, 2024 11:13:54 PM UTC
<
rdar://problem/122586298
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug