Bug 203769 – Port FontFaceSet to the HTML5 event loop

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Chris Dumez]

Port FontFaceSet to the HTML5 event loop.

[Chris Dumez]

Created attachment 382644 [details]
Patch

[Sam Weinig]

Comment on attachment 382644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382644&action=review

> Source/WebCore/css/FontFaceSet.cpp:-204
> -        m_taskQueue->enqueueTask([this] {

What is the reason for not removing m_taskQueue completely? It looks like it is now just created and then nothing is done with it.

[Chris Dumez]

(In reply to Sam Weinig from comment #2)
> Comment on attachment 382644 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382644&action=review
> 
> > Source/WebCore/css/FontFaceSet.cpp:-204
> > -        m_taskQueue->enqueueTask([this] {
> 
> What is the reason for not removing m_taskQueue completely? It looks like it
> is now just created and then nothing is done with it.

It sounds like I forgot? I wrote this during the contributor meeting :P will fix.

[Chris Dumez]

Created attachment 382688 [details]
Patch

[Alexey Proskuryakov]

We’re having some troubles with iOS EWS now, but for event loop changes, it’s probably worth waiting until those are cleared! Please also check detailed results from the testers, as EWS logic tends to swipe flaky tests under the carpet.

[Chris Dumez]

Created attachment 382710 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382710 [details]
Patch

Clearing flags on attachment: 382710

Committed r252016: <https://trac.webkit.org/changeset/252016>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56881893>

[Ross Kirsling]

This broke WinCairo, as demonstrated by EWS.

[Chris Dumez]

(In reply to Ross Kirsling from comment #10)
> This broke WinCairo, as demonstrated by EWS.

Sorry, was fixed later in https://trac.webkit.org/changeset/252028/webkit.