Bug 203765 – REGRESSION(r248696): Element Click on Mac is adding an extra page topContentInsets to y-coordinate

• Status: RESOLVED
• Resolution: FIXED
• Component: WebDriver

[Blaze Burg]

.

[Blaze Burg]

<rdar://problem/56014369>

[Blaze Burg]

Created attachment 382635 [details]
Patch

[Devin Rousso]

Comment on attachment 382635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382635&action=review

r=me, an all negative diff I love it =D

> Source/WebKit/ChangeLog:11
> +        The topContentInsets is now accounted for by rootViewToWindow(), so don't add it in manually.

Shouldn't this just be "The topContentInset is"?

Also, was this something that changed recently (the "now" makes it seem like this wasn't the case before)?  If so, do you know what revision?  If not, please remove the "now".

[Blaze Burg]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 382635 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382635&action=review
> 
> r=me, an all negative diff I love it =D
> 
> > Source/WebKit/ChangeLog:11
> > +        The topContentInsets is now accounted for by rootViewToWindow(), so don't add it in manually.
> 
> Shouldn't this just be "The topContentInset is"?

Yes.

> 
> Also, was this something that changed recently (the "now" makes it seem like
> this wasn't the case before)?  If so, do you know what revision?  If not,
> please remove the "now".

This method was reworked this spring to work in terms of viewport coordinates. I'll just drop 'now' since there were many relevant commits in this chain of regressions.

[Blaze Burg]

Committed r251948: <https://trac.webkit.org/changeset/251948>