Bug 203762 - Python 3: Add support in webkitpy.style
Summary: Python 3: Add support in webkitpy.style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-01 14:42 PDT by Jonathan Bedard
Modified: 2019-11-14 16:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.31 KB, patch)
2019-11-14 08:11 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (16.33 KB, patch)
2019-11-14 11:12 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-11-01 14:42:57 PDT 
Our style checker should support Python 3.
Comment 1 Jonathan Bedard 2019-11-14 08:11:12 PST 
Created attachment 383556 [details]
Patch
Comment 2 Jonathan Bedard 2019-11-14 11:12:09 PST 
Created attachment 383561 [details]
Patch
Comment 3 Jonathan Bedard 2019-11-14 11:13:52 PST 
This patch lets us run check-webkit-style with Python 3, via:

python3 Tools/Scripts/check-webkit-style

Not changing the shebang, but on systems where python maps to Python 3, check-webkit-style should work once this lands.
Comment 4 WebKit Commit Bot 2019-11-14 16:17:04 PST 
Comment on attachment 383561 [details]
Patch

Clearing flags on attachment: 383561

Committed r252468: <https://trac.webkit.org/changeset/252468>
Comment 5 WebKit Commit Bot 2019-11-14 16:17:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-14 16:18:19 PST 
<rdar://problem/57209242>