Bug 203755 - Update SameSite tests for new semantics for empty and invalid SameSite attribute
Summary: Update SameSite tests for new semantics for empty and invalid SameSite attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-01 13:43 PDT by Daniel Bates
Modified: 2019-11-06 15:03 PST (History)
3 users (show)

See Also:

Attachments
Patch (56.51 KB, patch)
2019-11-01 13:55 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (58.20 KB, patch)
2019-11-06 15:01 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-11-01 13:43:02 PDT 
Update the tests and test expectations following CFNetwork change <rdar://problem/42290578> as we now only recognize SameSite=Strict and SameSite=Lax. That is, we no longer treat SameSite= or SameSite=<some garbage value> as SameSite=Strict.
Comment 1 Daniel Bates 2019-11-01 13:43:27 PDT 
<rdar://problem/50816282>
Comment 2 Daniel Bates 2019-11-01 13:55:08 PDT 
Created attachment 382623 [details]
Patch
Comment 3 Brent Fulgham 2019-11-06 09:17:29 PST 
Comment on attachment 382623 [details]
Patch

r=me
Comment 4 Daniel Bates 2019-11-06 09:34:56 PST 
Comment on attachment 382623 [details]
Patch

Clearing flags on attachment: 382623

Committed r252138: <https://trac.webkit.org/changeset/252138>
Comment 5 Daniel Bates 2019-11-06 09:34:58 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Truitt Savell 2019-11-06 11:56:01 PST 
The changes in https://trac.webkit.org/changeset/252138/webkit

broek 8 http/tests/cookies/same-site/ tests

tracking in https://bugs.webkit.org/show_bug.cgi?id=203910
Comment 7 Truitt Savell 2019-11-06 14:21:26 PST 
Reverted r252138 for reason:

Caused 8 http/tests/cookies/same-site/ to fail

Committed r252149: <https://trac.webkit.org/changeset/252149>
Comment 8 Daniel Bates 2019-11-06 15:01:57 PST 
Created attachment 382963 [details]
To Land
Comment 9 Daniel Bates 2019-11-06 15:03:22 PST 
Committed r252153: <https://trac.webkit.org/changeset/252153>