RESOLVED FIXED 203752
The offline assembler is wrong about which immediates are supported by and/or/xor on ARM64 
https://bugs.webkit.org/show_bug.cgi?id=203752
Summary The offline assembler is wrong about which immediates are supported by and/or...
Robin Morisset
Reported 2019-11-01 13:04:08 PDT
It uses the same list of valid immediates for and/or/xor as for add/sub/mul but it is much more subtle, see: https://dinfuehr.github.io/blog/encoding-of-immediate-values-on-aarch64/. This is fine for now by chance, but changing the layout of ArithProfile can cause us to emit invalid constants in the generated assembly (this is blocking https://bugs.webkit.org/show_bug.cgi?id=202832).
Attachments
Patch (5.36 KB, patch)
2019-11-01 13:40 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (5.36 KB, patch)
2019-11-01 13:46 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2019-11-01 14:05 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-11-01 13:40:48 PDT
Created attachment 382616 [details] Patch
Robin Morisset
Comment 2 2019-11-01 13:46:49 PDT
Created attachment 382618 [details] Patch
Robin Morisset
Comment 3 2019-11-01 14:05:01 PDT
Created attachment 382626 [details] Patch remove now obsolete/wrong assert.
Tadeu Zagallo
Comment 4 2019-11-02 12:28:04 PDT
Comment on attachment 382626 [details] Patch r=me
WebKit Commit Bot
Comment 5 2019-11-02 13:12:45 PDT
Comment on attachment 382626 [details] Patch Clearing flags on attachment: 382626 Committed r251966: <https://trac.webkit.org/changeset/251966>
WebKit Commit Bot
Comment 6 2019-11-02 13:12:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-02 13:13:15 PDT
<rdar://problem/56842399>
Note You need to log in before you can comment on or make changes to this bug.