Bug 203742 - Error: redefinition of 'TransferFunction'
Summary: Error: redefinition of 'TransferFunction'
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
Depends on:
Reported: 2019-11-01 09:33 PDT by cathiechen
Modified: 2019-11-04 07:38 PST (History)
9 users (show)

See Also:

Patch (6.28 KB, patch)
2019-11-01 10:00 PDT, cathiechen
no flags Details | Formatted Diff | Diff
Patch (6.27 KB, patch)
2019-11-03 08:07 PST, cathiechen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2019-11-01 09:33:08 PDT
There is a redefinition error of `TransferFunction` if VideoTextureCopierCV.cpp and MediaEngineConfigurationFactoryCocoa.cpp are put in a same UnifiedSource file.

Can we rename one of them?

./platform/graphics/cv/VideoTextureCopierCV.cpp:54:12: error: redefinition of 'TransferFunction'
enum class TransferFunction {
In file included from /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/WebKitBuild/Release-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource253.cpp:1:
In file included from ./platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:32:
In file included from /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Source/WebCore/platform/MediaCapabilitiesDecodingInfo.h:29:
In file included from /Vol
In file included from /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Source/WebCore/platform/mediacapabilities/MediaConfiguration.h:29:
In file included from /Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Source/WebCore/platform/mediacapabilities/VideoConfiguration.h:30:
/Volumes/Data/worker/iOS-13-Simulator-Build-EWS/build/Source/WebCore/platform/mediacapabilities/TransferFunction.h:30:12: note: previous definition is here
enum class TransferFunction {
Comment 1 Jer Noble 2019-11-01 09:36:10 PDT
Yes, let’s rename the one in VideoTextureCopierCV.cpp.
Comment 2 cathiechen 2019-11-01 09:45:13 PDT
OK, will do:)
Comment 3 cathiechen 2019-11-01 10:00:07 PDT
Created attachment 382589 [details]
Comment 4 cathiechen 2019-11-03 08:07:47 PST
Created attachment 382707 [details]
Comment 5 WebKit Commit Bot 2019-11-04 07:38:44 PST
Comment on attachment 382707 [details]

Clearing flags on attachment: 382707

Committed r251988: <https://trac.webkit.org/changeset/251988>
Comment 6 WebKit Commit Bot 2019-11-04 07:38:46 PST
All reviewed patches have been landed.  Closing bug.