Bug 203737 - [JSC] OSR exit to LLInt is broken on MIPS
Summary: [JSC] OSR exit to LLInt is broken on MIPS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-01 07:39 PDT by Caio Lima
Modified: 2019-11-20 15:13 PST (History)
14 users (show)

See Also:

Attachments
Patch (13.80 KB, patch)
2019-11-19 06:24 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (14.19 KB, patch)
2019-11-19 08:18 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2019-11-01 07:39:43 PDT 
See list of failing tests in https://bugs.webkit.org/show_bug.cgi?id=203710
Comment 1 Guillaume Emont 2019-11-08 09:23:57 PST 
Skipping another failing test with similar backtrace in Bug 204003.
Comment 2 Caio Lima 2019-11-14 12:08:43 PST 
New broken test:

stress/ensure-code-block-is-not-precise-allocation.js.dfg-eager
Comment 3 Caio Lima 2019-11-19 06:24:34 PST 
Created attachment 383862 [details]
Patch
Comment 4 Guillaume Emont 2019-11-19 06:56:40 PST 
Comment on attachment 383862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383862&action=review

This looks like the right approach, assuming tests pass.

> Source/JavaScriptCore/ChangeLog:14
> +        `OFFLINE_ASM_CPLOAD` macro) immideatly after a non-local label. With

typo: immediately

> Source/JavaScriptCore/ChangeLog:19
> +        emmit code using the correct register required to recalculate `$gp`.

typo: emit
Comment 5 Caio Lima 2019-11-19 08:18:56 PST 
Created attachment 383870 [details]
Patch
Comment 6 Yusuke Suzuki 2019-11-19 20:01:11 PST 
Comment on attachment 383870 [details]
Patch

r=me
Comment 7 Caio Lima 2019-11-20 12:07:02 PST 
Comment on attachment 383870 [details]
Patch

Thank you very much for the review!
Comment 8 WebKit Commit Bot 2019-11-20 13:30:53 PST 
The commit-queue encountered the following flaky tests while processing attachment 383870 [details]:

The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2019-11-20 13:31:02 PST 
The commit-queue encountered the following flaky tests while processing attachment 383870 [details]:

imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.any.html bug 204421 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2019-11-20 15:12:49 PST 
Comment on attachment 383870 [details]
Patch

Clearing flags on attachment: 383870

Committed r252713: <https://trac.webkit.org/changeset/252713>
Comment 11 WebKit Commit Bot 2019-11-20 15:12:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-11-20 15:13:17 PST 
<rdar://problem/57374650>