Bug 203736 - [ews] Pass clobber-old-results parameter to run-webkit-tests
Summary: [ews] Pass clobber-old-results parameter to run-webkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-01 07:17 PDT by Aakash Jain
Modified: 2019-11-01 10:28 PDT (History)
7 users (show)

See Also:


Attachments
Patch (10.61 KB, patch)
2019-11-01 07:19 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-01 07:17:20 PDT
Pass --clobber-old-results to run-webkit-tests. This will also match will build.webkit.org configuration: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py#L418
Comment 1 Aakash Jain 2019-11-01 07:19:55 PDT
Created attachment 382575 [details]
Patch
Comment 2 Aakash Jain 2019-11-01 07:22:56 PDT
I haven't tested this one on uat instance. This is a speculative (and a simple) change to make the EWS configuration similar to build.webkit.org. Also logically, passing --clobber-test-results shouldn't cause any issue as it's just more cleanup.
Comment 3 Jonathan Bedard 2019-11-01 09:32:35 PDT
Comment on attachment 382575 [details]
Patch

This change is obviously correct, we should have been doing it from the beginning.
Comment 4 WebKit Commit Bot 2019-11-01 10:27:43 PDT
Comment on attachment 382575 [details]
Patch

Clearing flags on attachment: 382575

Committed r251927: <https://trac.webkit.org/changeset/251927>
Comment 5 WebKit Commit Bot 2019-11-01 10:27:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-01 10:28:18 PDT
<rdar://problem/56820127>