Bug 203721 - gcSafeMemmove references undefined slowPathBackwardsMemmove on non-gcc compatible compilers
Summary: gcSafeMemmove references undefined slowPathBackwardsMemmove on non-gcc compat...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
Keywords: InRadar
Depends on:
Reported: 2019-10-31 21:14 PDT by Tadeu Zagallo
Modified: 2019-11-03 10:19 PST (History)
9 users (show)

See Also:

Patch (1.52 KB, patch)
2019-10-31 21:15 PDT, Tadeu Zagallo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-10-31 21:14:15 PDT
Comment 1 Tadeu Zagallo 2019-10-31 21:15:49 PDT
Created attachment 382547 [details]
Comment 2 Fujii Hironori 2019-10-31 21:17:20 PDT
Comment on attachment 382547 [details]

LGTM. Thank you very much.
Comment 3 Tadeu Zagallo 2019-10-31 21:18:54 PDT
Thanks for the review!
Comment 4 WebKit Commit Bot 2019-10-31 22:01:46 PDT
Comment on attachment 382547 [details]

Clearing flags on attachment: 382547

Committed r251909: <https://trac.webkit.org/changeset/251909>
Comment 5 WebKit Commit Bot 2019-10-31 22:01:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-10-31 22:02:18 PDT
Comment 7 Alexey Proskuryakov 2019-11-02 17:52:56 PDT
Reverted in r251967 together with r251875, because this patch was conflicting with the rollback. Sorry for the inconvenience.
Comment 8 Alexey Proskuryakov 2019-11-03 10:19:57 PST
I'm not sure if this was a fix after r251875, or a fix of its own (didn't look at the code). Please close or re-land as appropriate.