Bug 203719 – Web Inspector: Sources: tab isn't visible after removal of Debugger Tab and Resources Tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

If you'd never previously opened the Sources Tab, but had already used Web Inspector, it won't appear after the Resources/Debugger Tabs were removed.

[Devin Rousso]

<rdar://problem/56802389>

[Devin Rousso]

Created attachment 382545 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382545 [details]
Patch

Clearing flags on attachment: 382545

Committed r251922: <https://trac.webkit.org/changeset/251922>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Blaze Burg]

Comment on attachment 382545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382545&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:154
> +    // Replace the Debugger/Resources Tab with the Sources Tab.

Please extract this into a separate function. Maybe even a separate file like MigrationUtilities.js. When we decide this code is no longer worth the trouble (say, Catalina + 1, or based on telemetry showing its use has diminished) then we can easily remove it.

> Source/WebInspectorUI/UserInterface/Base/Main.js:155
> +    let debuggerIndex = WI._openTabsSetting.value.indexOf("debugger");

It seems weird we have a symbolic name for "debugger" or "resources" tab?

[Devin Rousso]

Comment on attachment 382545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382545&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:154
>> +    // Replace the Debugger/Resources Tab with the Sources Tab.
> 
> Please extract this into a separate function. Maybe even a separate file like MigrationUtilities.js. When we decide this code is no longer worth the trouble (say, Catalina + 1, or based on telemetry showing its use has diminished) then we can easily remove it.

This already landed in r251922 😅

>> Source/WebInspectorUI/UserInterface/Base/Main.js:155
>> +    let debuggerIndex = WI._openTabsSetting.value.indexOf("debugger");
> 
> It seems weird we have a symbolic name for "debugger" or "resources" tab?

This was the value of `WI.DebuggerTabContentView.Type` and `WI.ResourcesTabContentView.Type`.  It's the identifier we used for saving/restoring.