Bug 203713 - Take down the gesture snapshot early when the back/forward cache is not leveraged
Summary: Take down the gesture snapshot early when the back/forward cache is not lever...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-31 18:46 PDT by Chris Dumez
Modified: 2019-12-04 10:48 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.44 KB, patch)
2019-10-31 18:53 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.44 KB, patch)
2019-10-31 18:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.98 KB, patch)
2019-10-31 19:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-31 18:46:11 PDT
Take down the gesture snapshot as soon as the gesture is done when the back/forward cache is not leveraged. Otherwise, the snapshot may stay up for a long time (while we load, parse and restore scroll position) and it looks to the user as if the view is unresponsive. Showing the back loading in such cases is less confusing.
Comment 1 Radar WebKit Bug Importer 2019-10-31 18:49:51 PDT
<rdar://problem/56803910>
Comment 2 Chris Dumez 2019-10-31 18:53:49 PDT
Created attachment 382534 [details]
Patch
Comment 3 Chris Dumez 2019-10-31 18:55:15 PDT
Created attachment 382535 [details]
Patch
Comment 4 Chris Dumez 2019-10-31 19:14:38 PDT
Created attachment 382538 [details]
Patch
Comment 5 WebKit Commit Bot 2019-10-31 21:07:44 PDT
Comment on attachment 382538 [details]
Patch

Clearing flags on attachment: 382538

Committed r251907: <https://trac.webkit.org/changeset/251907>
Comment 6 WebKit Commit Bot 2019-10-31 21:07:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2019-11-06 15:53:49 PST
Reverted r251907 for reason:

Causes white flashing in some cases <rdar://problem/56957850>

Committed r252155: <https://trac.webkit.org/changeset/252155>