Bug 203695 – Web Inspector: Color picker: incorrect saturation when selecting color on color square

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 382496 [details]
[Image] Bug

For instance, the top middle point of the color square should have:

100% saturation
75% lightness

Instead, it shows:

50% saturation
75% lightness

[Radar WebKit Bug Importer]

<rdar://problem/56793697>

[Nikita Vasilyev]

Created attachment 382498 [details]
Patch

[Matt Baker]

Comment on attachment 382498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382498&action=review

r=me, looks good!

> Source/WebInspectorUI/UserInterface/Models/Color.js:270
> +    }

Per our offline discussion, I agree that this reads closer to the conversion algorithm on Wikipedia:

static hsv2hsl(h, s, v)
{
    h = Number.constrain(h, 0, 360);
    s = Number.constrain(s, 0, 100) / 100;
    v = Number.constrain(v, 0, 100) / 100;

    let l = v - v * s / 2;
    let s;
    if (l === 0 || l === 1)
        s = 0;
    else
        s = (v - l) / Math.min(l, 1 - l);

    return [h, s * 100, l * 100];
}

[Nikita Vasilyev]

Created attachment 382502 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382502 [details]
Patch

Clearing flags on attachment: 382502

Committed r251885: <https://trac.webkit.org/changeset/251885>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.