Bug 203694 - Rename Wasm::CodeBlock to Wasm::CalleeGroup
Summary: Rename Wasm::CodeBlock to Wasm::CalleeGroup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 234101 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-10-31 13:30 PDT by Tadeu Zagallo
Modified: 2021-12-16 15:46 PST (History)
11 users (show)

See Also:

Attachments
Patch (132.29 KB, patch)
2021-12-15 16:18 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-10-31 13:30:35 PDT 
It's just not a CodeBlock, and it should be called something else.
Comment 1 Yusuke Suzuki 2021-12-15 16:18:22 PST 
Created attachment 447297 [details]
Patch
Comment 2 Mark Lam 2021-12-15 16:23:28 PST 
Comment on attachment 447297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447297&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        This is not a CodeBlock. And it is confusing name to JSC::CodeBlock.

I suggest rephrasing as “And the name causes confusion with JSC::CodeBlock, which is not at all related.”
Comment 3 Yusuke Suzuki 2021-12-15 17:04:25 PST 
Comment on attachment 447297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447297&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        This is not a CodeBlock. And it is confusing name to JSC::CodeBlock.
> 
> I suggest rephrasing as “And the name causes confusion with JSC::CodeBlock, which is not at all related.”

Thanks, fixed!
Comment 4 Yusuke Suzuki 2021-12-15 18:15:52 PST 
Committed r287122 (245306@trunk): <https://commits.webkit.org/245306@trunk>
Comment 5 Radar WebKit Bug Importer 2021-12-15 18:17:38 PST 
<rdar://problem/86552840>
Comment 6 Saam Barati 2021-12-16 15:46:04 PST 
*** Bug 234101 has been marked as a duplicate of this bug. ***