Bug 203680 - Port ServiceWorkerContainer to the HTML5 event loop
Summary: Port ServiceWorkerContainer to the HTML5 event loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 202293 203714
  Show dependency tree / graph
 
Reported: 2019-10-31 08:03 PDT by Chris Dumez
Modified: 2019-11-01 12:35 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.20 KB, patch)
2019-10-31 08:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.71 KB, patch)
2019-10-31 10:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (9.74 KB, patch)
2019-10-31 13:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.85 KB, patch)
2019-10-31 13:34 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.58 KB, patch)
2019-10-31 16:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-10-31 08:03:38 PDT 
Port ServiceWorkerContainer to the HTML5 event loop, instead of having its own SuspendableTaskQueue.
Comment 1 Chris Dumez 2019-10-31 08:06:27 PDT 
Created attachment 382459 [details]
Patch
Comment 2 Chris Dumez 2019-10-31 10:51:33 PDT 
Created attachment 382478 [details]
Patch
Comment 3 Chris Dumez 2019-10-31 13:07:02 PDT 
Created attachment 382490 [details]
Patch
Comment 4 Chris Dumez 2019-10-31 13:34:33 PDT 
Created attachment 382494 [details]
Patch
Comment 5 Ryosuke Niwa 2019-10-31 16:01:12 PDT 
Comment on attachment 382494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382494&action=review

> Source/WebCore/workers/WorkerEventLoop.cpp:38
> +    auto eventLoop = adoptRef(*new WorkerEventLoop(context));
> +    eventLoop->suspendIfNeeded();
> +    return eventLoop;

Maybe we can just do this in the constructor?

> Source/WebCore/workers/WorkerEventLoop.cpp:45
> +    eventLoop->suspendIfNeeded();

Ditto.
Comment 6 Chris Dumez 2019-10-31 16:44:07 PDT 
Created attachment 382519 [details]
Patch
Comment 7 WebKit Commit Bot 2019-11-01 12:34:39 PDT 
Comment on attachment 382519 [details]
Patch

Clearing flags on attachment: 382519

Committed r251934: <https://trac.webkit.org/changeset/251934>
Comment 8 WebKit Commit Bot 2019-11-01 12:34:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-01 12:35:16 PDT 
<rdar://problem/56824994>