Bug 203678 - [EWS] Limit API tests failures to display in the status-bubble tooltip and buildbot summary
Summary: [EWS] Limit API tests failures to display in the status-bubble tooltip and bu...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-10-31 07:18 PDT by Aakash Jain
Modified: 2020-07-08 09:02 PDT (History)
6 users (show)

See Also:

Patch (2.69 KB, patch)
2019-10-31 07:50 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-10-31 07:18:24 PDT
Sometimes a patch can break hundreds of API tests. In those cases, the status-bubble tries to display all those hundreds of failures, and becomes unreadable. Similarly buildbot build page display all the failing test names in the summary string, and becomes pretty unreadable. For e.g.: https://ews-build.webkit.org/#/builders/3/builds/11258 has 788 API test failures and the build page is unreadable.

We should limit the number of failures to display in the status-bubble and summary strings. Complete list of failing tests can still be seen in the logs of the test-run and the json output.
Comment 1 Aakash Jain 2019-10-31 07:50:40 PDT
Created attachment 382458 [details]
Comment 2 Aakash Jain 2019-10-31 07:53:05 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/4/builds/61
Comment 3 Jonathan Bedard 2019-10-31 08:18:21 PDT
(In reply to Aakash Jain from comment #2)
> Sample run: https://ews-build.webkit-uat.org/#/builders/4/builds/61

What does this look like in tooltips?
Comment 4 Aakash Jain 2019-10-31 08:19:21 PDT
> What does this look like in tooltips?
Comment 5 WebKit Commit Bot 2019-10-31 08:42:56 PDT
Comment on attachment 382458 [details]

Clearing flags on attachment: 382458

Committed r251849: <https://trac.webkit.org/changeset/251849>
Comment 6 WebKit Commit Bot 2019-10-31 08:42:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-31 08:43:18 PDT
Comment 8 Aakash Jain 2019-11-07 10:54:38 PST
Recent examples where this change was helpful in keeping the UI readable:

Corresponding Status bubble in: https://bugs.webkit.org/show_bug.cgi?id=203880