WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 203678
[EWS] Limit API tests failures to display in the status-bubble tooltip and buildbot summary
https://bugs.webkit.org/show_bug.cgi?id=203678
Summary
[EWS] Limit API tests failures to display in the status-bubble tooltip and bu...
Aakash Jain
Reported
2019-10-31 07:18:24 PDT
Sometimes a patch can break hundreds of API tests. In those cases, the status-bubble tries to display all those hundreds of failures, and becomes unreadable. Similarly buildbot build page display all the failing test names in the summary string, and becomes pretty unreadable. For e.g.:
https://ews-build.webkit.org/#/builders/3/builds/11258
has 788 API test failures and the build page is unreadable. We should limit the number of failures to display in the status-bubble and summary strings. Complete list of failing tests can still be seen in the logs of the test-run and the json output.
Attachments
Patch
(2.69 KB, patch)
2019-10-31 07:50 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2019-10-31 07:50:40 PDT
Created
attachment 382458
[details]
Patch
Aakash Jain
Comment 2
2019-10-31 07:53:05 PDT
Sample run:
https://ews-build.webkit-uat.org/#/builders/4/builds/61
Jonathan Bedard
Comment 3
2019-10-31 08:18:21 PDT
(In reply to Aakash Jain from
comment #2
)
> Sample run:
https://ews-build.webkit-uat.org/#/builders/4/builds/61
What does this look like in tooltips?
Aakash Jain
Comment 4
2019-10-31 08:19:21 PDT
> What does this look like in tooltips?
https://ews.webkit-uat.org/status-bubble/381964/
WebKit Commit Bot
Comment 5
2019-10-31 08:42:56 PDT
Comment on
attachment 382458
[details]
Patch Clearing flags on attachment: 382458 Committed
r251849
: <
https://trac.webkit.org/changeset/251849
>
WebKit Commit Bot
Comment 6
2019-10-31 08:42:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-10-31 08:43:18 PDT
<
rdar://problem/56782288
>
Aakash Jain
Comment 8
2019-11-07 10:54:38 PST
Recent examples where this change was helpful in keeping the UI readable:
https://ews-build.webkit.org/#/builders/9/builds/11552
https://ews-build.webkit.org/#/builders/3/builds/11613
Corresponding Status bubble in:
https://bugs.webkit.org/show_bug.cgi?id=203880
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug