RESOLVED FIXED Bug 203668
Web Inspector: REGRESSION(r251038): Elements: Computed: variables are shown in the Properties section instead of in the Variables section 
https://bugs.webkit.org/show_bug.cgi?id=203668
Summary Web Inspector: REGRESSION(r251038): Elements: Computed: variables are shown i...
Devin Rousso
Reported 2019-10-31 01:07:56 PDT
.
Attachments
Patch (6.64 KB, patch)
2019-10-31 01:12 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-10-31 01:12:15 PDT
Created attachment 382439 [details] Patch
Matt Baker
Comment 2 2019-10-31 12:29:26 PDT
Comment on attachment 382439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112 > + set propertyVisibilityMode(propertyVisibilityMode) This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`?
Devin Rousso
Comment 3 2019-10-31 14:15:58 PDT
Comment on attachment 382439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review >> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112 >> + set propertyVisibilityMode(propertyVisibilityMode) > > This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`? This is just putting back what was removed in r251038. Also, `WI.SpreadsheetCSSStyleDeclarationSection` has a similarly named concept.
Matt Baker
Comment 4 2019-10-31 14:30:19 PDT
Comment on attachment 382439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review >>> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112 >>> + set propertyVisibilityMode(propertyVisibilityMode) >> >> This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`? > > This is just putting back what was removed in r251038. Also, `WI.SpreadsheetCSSStyleDeclarationSection` has a similarly named concept. Okie dokie!
WebKit Commit Bot
Comment 5 2019-10-31 15:00:29 PDT
Comment on attachment 382439 [details] Patch Clearing flags on attachment: 382439 Committed r251883: <https://trac.webkit.org/changeset/251883>
WebKit Commit Bot
Comment 6 2019-10-31 15:00:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-10-31 15:02:40 PDT
<rdar://problem/56796756>
Note You need to log in before you can comment on or make changes to this bug.