Bug 203668 - Web Inspector: REGRESSION(r251038): Elements: Computed: variables are shown in the Properties section instead of in the Variables section
Summary: Web Inspector: REGRESSION(r251038): Elements: Computed: variables are shown i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 200554
Blocks:
  Show dependency tree / graph
 
Reported: 2019-10-31 01:07 PDT by Devin Rousso
Modified: 2019-10-31 15:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.64 KB, patch)
2019-10-31 01:12 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-10-31 01:07:56 PDT 
.
Comment 1 Devin Rousso 2019-10-31 01:12:15 PDT 
Created attachment 382439 [details]
Patch
Comment 2 Matt Baker 2019-10-31 12:29:26 PDT 
Comment on attachment 382439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112
> +    set propertyVisibilityMode(propertyVisibilityMode)

This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`?
Comment 3 Devin Rousso 2019-10-31 14:15:58 PDT 
Comment on attachment 382439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review

>> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112
>> +    set propertyVisibilityMode(propertyVisibilityMode)
> 
> This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`?

This is just putting back what was removed in r251038.  Also, `WI.SpreadsheetCSSStyleDeclarationSection` has a similarly named concept.
Comment 4 Matt Baker 2019-10-31 14:30:19 PDT 
Comment on attachment 382439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382439&action=review

>>> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:112
>>> +    set propertyVisibilityMode(propertyVisibilityMode)
>> 
>> This is kind of wordy. I think the context is clear, how about just naming the parameter `mode`?
> 
> This is just putting back what was removed in r251038.  Also, `WI.SpreadsheetCSSStyleDeclarationSection` has a similarly named concept.

Okie dokie!
Comment 5 WebKit Commit Bot 2019-10-31 15:00:29 PDT 
Comment on attachment 382439 [details]
Patch

Clearing flags on attachment: 382439

Committed r251883: <https://trac.webkit.org/changeset/251883>
Comment 6 WebKit Commit Bot 2019-10-31 15:00:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-10-31 15:02:40 PDT 
<rdar://problem/56796756>