Bug 203654 - Rename AccessibilityObject::matchedParent as Accessibility::findAncestor and re-implement in a generic way so that can be used with both AccessibilityObjects and AXIsolatedTreeNodes.
Summary: Rename AccessibilityObject::matchedParent as Accessibility::findAncestor and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-30 19:01 PDT by Andres Gonzalez
Modified: 2019-10-31 13:00 PDT (History)
11 users (show)

See Also:


Attachments
Patch (24.09 KB, patch)
2019-10-30 19:12 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (24.10 KB, patch)
2019-10-31 05:32 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2019-10-30 19:01:45 PDT
Rename AccessibilityObject::matchedParent as Accessibility::findAncestor and re-implement in a generic way so that can be used with both AccessibilityObjects and AXIsolatedTreeNodes.
Comment 1 Andres Gonzalez 2019-10-30 19:12:15 PDT
Created attachment 382408 [details]
Patch
Comment 2 chris fleizach 2019-10-30 23:46:05 PDT
Comment on attachment 382408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382408&action=review

approved pending fixes of minor nits

> Source/WebCore/ChangeLog:12
> +        - Created the namespace Accessibility for implementation deatils that not need to be exposed to client code.

deatils > details

> Source/WebCore/accessibility/AccessibilityObjectInterface.h:1103
> +} // namespace ax

// namespace Accessibility
Comment 3 Andres Gonzalez 2019-10-31 05:32:45 PDT
Created attachment 382453 [details]
Patch
Comment 4 Andres Gonzalez 2019-10-31 05:36:26 PDT
Fixed the nits you pointed out. Thanks.
Comment 5 EWS 2019-10-31 05:37:53 PDT
Comment on attachment 382453 [details]
Patch

Rejecting attachment 382453 [details] from commit-queue.

andresg_22@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 WebKit Commit Bot 2019-10-31 12:59:28 PDT
Comment on attachment 382453 [details]
Patch

Clearing flags on attachment: 382453

Committed r251870: <https://trac.webkit.org/changeset/251870>
Comment 7 WebKit Commit Bot 2019-10-31 12:59:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-10-31 13:00:17 PDT
<rdar://problem/56791932>