Add the "Generic" TextTrackCue API presented at TPAC and FOMS. The API is disabled-by-default.
<rdar://problem/55675172>
Created attachment 382399 [details] WIP
Created attachment 382402 [details] WIP
Comment on attachment 382402 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=382402&action=review > Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:180 > +void MediaControlsHost::updateCaptionDisplaySizes(bool forceUpdate) A parameter of “enum class ForceUpdate { Yes, No }” might be nice here > Source/WebCore/html/shadow/MediaControlElements.cpp:1193 > + for (size_t i = 0; i < activeCues.size(); ++i) { Can this be?: for (auto& cue : activeCues) > Source/WebCore/html/shadow/MediaControlElements.cpp:1199 > + RefPtr<TextTrackCueBox> displayBox = cue->getDisplayTree(m_videoDisplaySize.size(), m_fontSize); Auto? > Source/WebCore/html/shadow/MediaControlElements.cpp:1223 > + if (!region) { Or: if (auto region = ....) { ... } else { ... }
Created attachment 382604 [details] Patch
Created attachment 382624 [details] Patch for landing
Comment on attachment 382624 [details] Patch for landing Clearing flags on attachment: 382624 Committed r251950: <https://trac.webkit.org/changeset/251950>
All reviewed patches have been landed. Closing bug.