Bug 203648 – Rejigger WKWebArchive headers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Brady Eidson]

Rejigger WKWebArchive headers

-Rename WKWebArchive.h to WKWebArchiveRef.h
-Add a new WKWebArchive.h that includes the Ref version

[Brady Eidson]

Created attachment 382398 [details]
Patch

[Brady Eidson]

Created attachment 382468 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382468 [details]
Patch

Clearing flags on attachment: 382468

Committed r251854: <https://trac.webkit.org/changeset/251854>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56785948>

[Andy Estes]

Comment on attachment 382468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382468&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebArchive.h:27
> +#include <WebKit/WKWebArchiveRef.h>

I know this is just for staging, but if it were to stay we should use #import here.

[Brady Eidson]

(In reply to Andy Estes from comment #6)
> Comment on attachment 382468 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382468&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebArchive.h:27
> > +#include <WebKit/WKWebArchiveRef.h>
> 
> I know this is just for staging, but if it were to stay we should use
> #import here.

It will NOT stay.

[Aakash Jain]

(In reply to WebKit Commit Bot from comment #3)
> Committed r251854: <https://trac.webkit.org/changeset/251854>
This seems to have broken the iOS build, as also indicated by EWS.

[Aakash Jain]

Relevant logs:
Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp:42:17: error: no previous prototype for function 'WKWebArchiveCreate' [-Werror,-Wmissing-prototypes]
WKWebArchiveRef WKWebArchiveCreate(WKWebArchiveResourceRef mainResourceRef, WKArrayRef subresourcesRef, WKArrayRef subframeArchivesRef)

Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp:72:12: error: no previous prototype for function 'WKWebArchiveCopySubframeArchives' [-Werror,-Wmissing-prototypes]
WKArrayRef WKWebArchiveCopySubframeArchives(WKWebArchiveRef webArchiveRef)

[Truitt Savell]

Reverted r251854 for reason:

Broke iOS build

Committed r251868: <https://trac.webkit.org/changeset/251868>

[Brady Eidson]

Created attachment 382595 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382595 [details]
Patch

Rejecting attachment 382595 [details] from commit-queue.

New failing tests:
requestidlecallback/requestidlecallback-document-gc.html
Full output: https://webkit-queues.webkit.org/results/13201898

[WebKit Commit Bot]

Created attachment 382613 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Brady Eidson]

(In reply to WebKit Commit Bot from comment #12)
> Comment on attachment 382595 [details]
> Patch
> 
> Rejecting attachment 382595 [details] from commit-queue.
> 
> New failing tests:
> requestidlecallback/requestidlecallback-document-gc.html
> Full output: https://webkit-queues.webkit.org/results/13201898

This patch did not cause this failure.

[Aakash Jain]

(In reply to Brady Eidson from comment #14)
> > New failing tests:
> > requestidlecallback/requestidlecallback-document-gc.html
> This patch did not cause this failure.
You are right. This is a flaky test. See: https://bugs.webkit.org/show_bug.cgi?id=203758

[WebKit Commit Bot]

Comment on attachment 382595 [details]
Patch

Clearing flags on attachment: 382595

Committed r251952: <https://trac.webkit.org/changeset/251952>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.