Bug 203633 – [iOS][WK2] Simplify process assertion handling for the network process and service worker processes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Simplify process assertion handling for the network process and service worker processes.

[Chris Dumez]

Created attachment 382373 [details]
Patch

[Chris Dumez]

Created attachment 382375 [details]
Patch

[Chris Dumez]

Comment on attachment 382375 [details]
Patch

ping review?

[Chris Dumez]

ping review?

[Alex Christensen]

Comment on attachment 382375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382375&action=review

> Source/WebKit/UIProcess/ProcessThrottler.h:95
> +    using ActivityVariant = Variant<std::nullptr_t, std::unique_ptr<BackgroundActivity>, std::unique_ptr<ForegroundActivity>>;

Could you use UniqueRef here?  You use the non-std::nullptr_t types as if they are always non-null, and right now the nullptr constructor is quite ambiguous.  I guess you only use the default constructor, but still...

[Chris Dumez]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 382375 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382375&action=review
> 
> > Source/WebKit/UIProcess/ProcessThrottler.h:95
> > +    using ActivityVariant = Variant<std::nullptr_t, std::unique_ptr<BackgroundActivity>, std::unique_ptr<ForegroundActivity>>;
> 
> Could you use UniqueRef here?  You use the non-std::nullptr_t types as if
> they are always non-null, and right now the nullptr constructor is quite
> ambiguous.  I guess you only use the default constructor, but still...

I am on the fence about this. I think this would mean having backgroundActivity() / foregroundActivity() return a UniqueRef instead of a unique_ptr, and then a lot of call sites would need to call moveToUniquePtr() to store it as a data member.

[Chris Dumez]

Created attachment 382754 [details]
Patch

[Chris Dumez]

Created attachment 382760 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 382760 [details]
Patch

Clearing flags on attachment: 382760

Committed r252011: <https://trac.webkit.org/changeset/252011>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56877865>