Bug 203629 – Issue mach sandbox extension to the WebContent process for "com.apple.distributed_notifications@1v3"

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit Misc.

[Per Arne Vollan]

This service is only being used by the injected bundle of WebKitTestRunner during layout tests, and we should therefore issue an extension instead of allowing the service in the WebContent sandbox.

[Radar WebKit Bug Importer]

<rdar://problem/56758948>

[Per Arne Vollan]

Created attachment 382359 [details]
Patch

[Brent Fulgham]

Comment on attachment 382359 [details]
Patch

Excellent! r=me

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 382359 [details]
> Patch
> 
> Excellent! r=me

The build is failing since this patch depends on https://bugs.webkit.org/show_bug.cgi?id=203618.

Thanks for reviewing!

[Alexey Proskuryakov]

> This service is only being used by the injected bundle of WebKitTestRunner during layout tests

That's so strange. Why? Can we stop WebKitTestRunner injected bundle from using it?

[Per Arne Vollan]

(In reply to Alexey Proskuryakov from comment #5)
> > This service is only being used by the injected bundle of WebKitTestRunner during layout tests
> 
> That's so strange. Why? Can we stop WebKitTestRunner injected bundle from
> using it?

This is caused by WebKitTestRunner's injected bundle calling CTFontManagerRegisterFontsForURLs. This seems to be related to activating test fonts.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 382474 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 382474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382474&action=review

> Source/WebCore/ChangeLog:3
> +        Issue mach sandbox extension to the WebContent process for "com.apple.distributed_notifications@1v3"

Seems like we don't need this any more? Because of bug 203697.

[Brent Fulgham]

(In reply to Alexey Proskuryakov from comment #8)
> Comment on attachment 382474 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382474&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Issue mach sandbox extension to the WebContent process for "com.apple.distributed_notifications@1v3"
> 
> Seems like we don't need this any more? Because of bug 203697.

I think we still want this, but should likely add it to one of our new "needed by InjectedBundle" init routines.

But this patch should change to move the blanket allow in Bug 203697 to a targeted allow based on Bundle ID.

[Brent Fulgham]

This turned out to not be needed.