WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 20361
Should WebKit implement on* event handler properties for transition events?
https://bugs.webkit.org/show_bug.cgi?id=20361
Summary
Should WebKit implement on* event handler properties for transition events?
Dean Jackson
Reported
2008-08-12 10:46:42 PDT
Currently the CSS Animation and Transition events are implemented using addEventListener and HTML attributes. Should we also add the .onwebkittransitionevent property on Element?
Attachments
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2008-08-12 10:50:36 PDT
One (cranky and sleepy) side of me says we should only support addEventListener for these events. Since I see the on* event attributes/properties as legacy. If we don't plan to add the properties we should remove the HTML attributes. Or we should just support all three and let people use whatever they like, even if HTML attributes and string values assigned to event properties are less performant.
Anthony Ricaud
Comment 2
2008-08-12 11:19:19 PDT
I think this is important because every event is accessible through properties. And this way of doing events is sometime more useful. For example, it's easier to delete events handler. It also seems strange to have HTML attributes without DOM properties.
Sam Weinig
Comment 3
2008-08-12 20:32:13 PDT
(In reply to
comment #1
)
> One (cranky and sleepy) side of me says we should only support addEventListener > for these events. Since I see the on* event attributes/properties as legacy. If > we don't plan to add the properties we should remove the HTML attributes.
What makes you feel that the attribute/property style event listeners is legacy. Many new specs, including XMLHttpRequest Level 2, include new ones.(In reply to
comment #2
)
> I think this is important because every event is accessible through properties. > And this way of doing events is sometime more useful. For example, it's easier > to delete events handler.
Just to be clear though, it is not true that every event is accessible through properties, the "message" event used by postMessage doesn't for example. That said, I do think attribute/property style event listeners should be added for consistency in the API.
Dean Jackson
Comment 4
2008-08-29 19:33:32 PDT
Turns out that this was mostly (but not quite) implemented. See
https://bugs.webkit.org/show_bug.cgi?id=20571
Dean Jackson
Comment 5
2008-09-01 17:15:02 PDT
Done now in blocking bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug