Bug 203601 - Opacity should always serialize as a number
Summary: Opacity should always serialize as a number
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-29 21:27 PDT by Simon Fraser (smfr)
Modified: 2019-11-01 21:00 PDT (History)
16 users (show)

See Also:


Attachments
Patch (4.04 KB, patch)
2019-10-29 21:27 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (293.71 KB, patch)
2019-10-29 22:14 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (6.16 KB, patch)
2019-10-29 23:03 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (6.32 KB, patch)
2019-10-30 08:28 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (16.87 KB, patch)
2019-10-30 09:45 PDT, Simon Fraser (smfr)
dino: review+
sabouhallawa: commit-queue-
Details | Formatted Diff | Diff
Patch (655.87 KB, patch)
2019-10-30 21:03 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-10-29 21:27:04 PDT
Opacity should always serialize as a number
Comment 1 Simon Fraser (smfr) 2019-10-29 21:27:53 PDT
Created attachment 382278 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-10-29 21:29:23 PDT
<rdar://problem/56733247>
Comment 3 Simon Fraser (smfr) 2019-10-29 22:14:11 PDT
Created attachment 382280 [details]
Patch
Comment 4 Simon Fraser (smfr) 2019-10-29 23:03:45 PDT
Created attachment 382284 [details]
Patch
Comment 5 Dirk Schulze 2019-10-30 00:32:39 PDT
Comment on attachment 382284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382284&action=review

The change looks good to me though I have no official reviewer status at the moment.

> Source/WebCore/css/StyleProperties.cpp:128
> +        case CSSPropertyOpacity:

Consider adding the SVG -opacity properties: fill, stroke, stop, flood. They behave just like opacity.
Comment 6 Simon Fraser (smfr) 2019-10-30 08:28:29 PDT
Created attachment 382316 [details]
Patch
Comment 7 Simon Fraser (smfr) 2019-10-30 09:45:02 PDT
Created attachment 382325 [details]
Patch
Comment 8 Said Abou-Hallawa 2019-10-30 13:13:03 PDT
The patch fixes these tests:

imported/w3c/web-platform-tests/svg/painting/parsing/stroke-opacity-valid.svg
imported/w3c/web-platform-tests/svg/painting/parsing/fill-opacity-valid.svg 
imported/w3c/web-platform-tests/svg/pservers/parsing/stop-opacity-valid.svg

They were unskipped in r251777. The expected files need to be rebaselined.
Comment 9 Simon Fraser (smfr) 2019-10-30 19:17:37 PDT
https://trac.webkit.org/changeset/251828/webkit
Comment 10 Simon Fraser (smfr) 2019-10-30 21:03:55 PDT Comment hidden (obsolete)
Comment 11 Simon Fraser (smfr) 2019-10-30 21:03:57 PDT Comment hidden (obsolete)