Bug 203597 - Fix color component rounding to match the CSS Color spec
Summary: Fix color component rounding to match the CSS Color spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-29 17:24 PDT by Simon Fraser (smfr)
Modified: 2019-11-18 15:15 PST (History)
17 users (show)

See Also:


Attachments
Patch (60.49 KB, patch)
2019-10-29 17:33 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (66.13 KB, patch)
2019-10-29 18:19 PDT, Simon Fraser (smfr)
thorton: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (13.92 MB, application/zip)
2019-10-29 19:39 PDT, EWS Watchlist
no flags Details
Patch (287.25 KB, patch)
2019-10-29 20:21 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (316.85 KB, patch)
2019-10-29 22:10 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (655.42 KB, patch)
2019-10-30 21:08 PDT, Simon Fraser (smfr)
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (14.77 MB, application/zip)
2019-10-31 08:27 PDT, EWS Watchlist
no flags Details
Patch (661.89 KB, patch)
2019-11-08 09:54 PST, Simon Fraser (smfr)
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews212 for win-future (14.92 MB, application/zip)
2019-11-11 22:35 PST, EWS Watchlist
no flags Details
Patch (724.55 KB, patch)
2019-11-18 11:46 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (746.10 KB, patch)
2019-11-18 12:53 PST, Simon Fraser (smfr)
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (14.72 MB, application/zip)
2019-11-18 14:42 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-10-29 17:24:53 PDT
Fix alpha value rounding to match the CSS Color spec
Comment 1 Simon Fraser (smfr) 2019-10-29 17:33:52 PDT
Created attachment 382256 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-10-29 17:34:16 PDT
<rdar://problem/56728546>
Comment 3 Simon Fraser (smfr) 2019-10-29 18:19:40 PDT
Created attachment 382259 [details]
Patch
Comment 4 Tim Horton 2019-10-29 19:01:49 PDT
Comment on attachment 382259 [details]
Patch

Please fix the tests
Comment 5 EWS Watchlist 2019-10-29 19:39:25 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2019-10-29 19:39:27 PDT Comment hidden (obsolete)
Comment 7 Simon Fraser (smfr) 2019-10-29 20:21:53 PDT Comment hidden (obsolete)
Comment 8 Simon Fraser (smfr) 2019-10-29 22:10:01 PDT Comment hidden (obsolete)
Comment 9 Simon Fraser (smfr) 2019-10-30 21:08:20 PDT Comment hidden (obsolete)
Comment 10 EWS Watchlist 2019-10-31 08:27:36 PDT Comment hidden (obsolete)
Comment 11 EWS Watchlist 2019-10-31 08:27:39 PDT Comment hidden (obsolete)
Comment 12 Simon Fraser (smfr) 2019-11-08 09:54:29 PST
Created attachment 383136 [details]
Patch
Comment 13 EWS Watchlist 2019-11-11 22:35:43 PST
Comment on attachment 383136 [details]
Patch

Attachment 383136 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13241677

New failing tests:
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-image-threshold.html
http/tests/navigation/page-cache-mediastream.html
fast/css/percentage-non-integer.html
fast/overflow/float-in-relpositioned.html
fast/canvas/canvas-fillPath-shadow.html
fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html
http/tests/navigation/page-cache-mediakeysession.html
svg/W3C-SVG-1.1/color-prop-02-f.svg
fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells.html
fast/table/border-collapsing/equal-precedence-resolution-vertical.html
fast/table/border-collapsing/equal-precedence-resolution.html
fast/block/basic/fieldset-stretch-to-legend.html
fast/text/shadow-translucent-fill.html
svg/W3C-SVG-1.1/color-prop-03-t.svg
http/tests/xmlhttprequest/access-control-and-redirects-async.html
fast/css/viewport-units-dynamic.html
fast/block/float/intruding-painted-twice.html
Comment 14 EWS Watchlist 2019-11-11 22:35:46 PST
Created attachment 383337 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 15 Simon Fraser (smfr) 2019-11-18 11:46:07 PST
Created attachment 383769 [details]
Patch
Comment 16 Simon Fraser (smfr) 2019-11-18 12:53:06 PST
Created attachment 383777 [details]
Patch
Comment 17 EWS Watchlist 2019-11-18 14:42:06 PST
Comment on attachment 383777 [details]
Patch

Attachment 383777 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13264994

New failing tests:
fast/css/percentage-non-integer.html
fast/overflow/float-in-relpositioned.html
fast/canvas/canvas-fillPath-shadow.html
svg/W3C-SVG-1.1/color-prop-02-f.svg
fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html
fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells.html
fast/css/viewport-units-dynamic.html
fast/table/border-collapsing/equal-precedence-resolution.html
fast/block/basic/fieldset-stretch-to-legend.html
fast/text/shadow-translucent-fill.html
svg/W3C-SVG-1.1/color-prop-03-t.svg
fast/table/border-collapsing/equal-precedence-resolution-vertical.html
fast/block/float/intruding-painted-twice.html
Comment 18 EWS Watchlist 2019-11-18 14:42:08 PST
Created attachment 383792 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 19 Simon Fraser (smfr) 2019-11-18 15:15:05 PST
https://trac.webkit.org/changeset/252598/webkit