Bug 20358 – [Gtk] font-variant: small-caps; is not working with libwebkit-1.0-1

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jelle de Jong]

I first when to the #webkit-gtk IRC channel to confirm the issue and got some good help from somebody there this person has a few days old build of webkit and experienced the same problem, so i am reporting this.

This is an example website that has the problem in its main title and menu's:
http://www.powercraft.nl/testing/

I am using debian sid and used midori for testing webkit

Package: libwebkit-1.0-1
Architecture: i386
Source: webkit
Version: 1.0.1-2

[Jelle de Jong]

Created attachment 22746 [details]
image of issue

[Jelle de Jong]

Created attachment 22747 [details]
image of issue

[Jelle de Jong]

The first attachment is with webkit (midori) the second is with gecko (firefox) as you can see there is no small-caps with webkit.

[Jonathon Jongsma (jonner)]

Created attachment 27607 [details]
possible fix

[Jonathon Jongsma (jonner)]

Comment on attachment 27607 [details]
possible fix

oops, forgot to mark for review

[Holger Freyther]

Comment on attachment 27607 [details]
possible fix


> -        desc.setSpecifiedSize(0.70f*fontDescription.computedSize());
> +        desc.setComputedSize(0.70f*fontDescription.computedSize());
           const FontPlatformData* pdata = new FontPlatformData(desc, desc.family().family());

Cool, what is completely missing from the ChangeLog is the answer to the question why this is the right fix. The FontPlatformData c'tor will use the computedPixelSize of the FontDescription so we will have to set the ComputedSize (like your patch does) and it also makes this statement look symmetric... (just scaling..). Taking a look at Mac and Win there might be more work ahead for custom fonts. I don't have a test case handy but we should be able to locate one.

[Holger Freyther]

Landed in r41246.