Bug 203556 - [GTK][WPE] Fix non-unified build after r251691
Summary: [GTK][WPE] Fix non-unified build after r251691
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-29 01:51 PDT by Adrian Perez
Modified: 2019-10-29 07:37 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2019-10-29 02:02 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-10-29 01:51:00 PDT
Commit r251691 introduced the following build failure:

../Source/WebCore/bindings/js/ScriptModuleLoader.cpp:218:23: error: use of undeclared identifier 'JSInternalPromise'; did you mean 'JSC::JSInternalPromise'?
    auto* jsPromise = JSInternalPromise::create(globalObject.vm(), globalObject.internalPromiseStructure());
                      ^~~~~~~~~~~~~~~~~
                      JSC::JSInternalPromise
DerivedSources/ForwardingHeaders/JavaScriptCore/JSInternalPromise.h:42:7: note: 'JSC::JSInternalPromise' declared here
class JSInternalPromise final : public JSPromise {
      ^
1 error generated.
Comment 1 Adrian Perez 2019-10-29 02:02:00 PDT
Created attachment 382168 [details]
Patch
Comment 2 WebKit Commit Bot 2019-10-29 07:36:39 PDT
Comment on attachment 382168 [details]
Patch

Clearing flags on attachment: 382168

Committed r251698: <https://trac.webkit.org/changeset/251698>
Comment 3 WebKit Commit Bot 2019-10-29 07:36:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-10-29 07:37:17 PDT
<rdar://problem/56705931>