RESOLVED FIXED 20353
Use animation events to clear the highligted line effect 
https://bugs.webkit.org/show_bug.cgi?id=20353
Summary Use animation events to clear the highligted line effect
Anthony Ricaud
Reported 2008-08-11 18:34:13 PDT
Now that those events are implemented, we can use them to offer a better behaviour, like restarting the effect every time the user clicks.
Attachments
Proposed patch (3.29 KB, patch)
2008-08-11 18:34 PDT, Anthony Ricaud 		timothy: review-
DetailsFormatted DiffDiff
Comments adressed (3.55 KB, patch)
2008-08-11 19:24 PDT, Anthony Ricaud 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anthony Ricaud
Comment 1 2008-08-11 18:34:44 PDT
Created attachment 22739 [details] Proposed patch
Timothy Hatcher
Comment 2 2008-08-11 19:02:48 PDT
Comment on attachment 22739 [details] Proposed patch + // Timeout to reset any animation still running Can you improve that comment? Something about coalesced style updates? + line.style.webkitAnimationName = 'none'; We also don't use single quote strings. I would prefer using setProperty fore these. + this.element.contentDocument.addEventListener("webkitAnimationEnd", function (event) { event.target.parentNode.removeStyleClass("webkit-highlighted-line");}, false); Can you put the function on the prototype like _documentMouseDown. + line.style.webkitAnimationName = ''; That would make more sense as: + line.style.removeProperty("-webkit-animation-name")
Anthony Ricaud
Comment 3 2008-08-11 19:24:09 PDT
Created attachment 22740 [details] Comments adressed
Timothy Hatcher
Comment 4 2008-08-11 21:21:20 PDT
Fixed in r35677.
Note You need to log in before you can comment on or make changes to this bug.