Bug 203522 - [ANGLE] Window Server blocking stops single GPU systems from creating a CGLPixelFormat
Summary: [ANGLE] Window Server blocking stops single GPU systems from creating a CGLPi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-10-28 14:26 PDT by Dean Jackson
Modified: 2019-10-29 13:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2019-10-28 14:30 PDT, Dean Jackson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-10-28 14:26:42 PDT 
[ANGLE] Window Server blocking stops single GPU systems from creating a CGLPixelFormat
Comment 1 Dean Jackson 2019-10-28 14:30:42 PDT 
Created attachment 382108 [details]
Patch
Comment 2 EWS Watchlist 2019-10-28 14:31:35 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Radar WebKit Bug Importer 2019-10-28 14:34:46 PDT 
<rdar://problem/56685302>
Comment 4 Radar WebKit Bug Importer 2019-10-28 14:35:08 PDT 
<rdar://problem/56685317>
Comment 5 Alex Christensen 2019-10-28 15:25:00 PDT 
Comment on attachment 382108 [details]
Patch

mSupportsGPUSwitching has one other use.  Is it still good, or could we remove it entirely?
Comment 6 Dean Jackson 2019-10-29 10:21:51 PDT 
(In reply to Alex Christensen from comment #5)
> Comment on attachment 382108 [details]
> Patch
> 
> mSupportsGPUSwitching has one other use.  Is it still good, or could we
> remove it entirely?

I want to minimize the diff from core ANGLE, so I think we should leave it in and let them decide.
Comment 7 Dean Jackson 2019-10-29 13:01:28 PDT 
Committed r251727: <https://trac.webkit.org/changeset/251727>