Bug 20352 - REGRESSION(r31030-31055): Choosing "Print window" from frame set prints blank page
Summary: REGRESSION(r31030-31055): Choosing "Print window" from frame set prints blank...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Printing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Beth Dakin
URL: http://www.tbdb.org/cgi-bin/expressio...
Keywords: InRadar, NeedsReduction, Regression
Depends on:
Blocks:
 
Reported: 2008-08-11 17:26 PDT by Gavin Sherlock
Modified: 2008-10-21 17:23 PDT (History)
1 user (show)

See Also:

Attachments
Reduction (2.15 KB, application/zip)
2008-10-21 17:13 PDT, Beth Dakin 		no flags Details
Patch (1.42 KB, patch)
2008-10-21 17:21 PDT, Beth Dakin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Sherlock 2008-08-11 17:26:41 PDT 
Steps to reproduce:

1.  Go to bug url
2.  Right click, and select "Print Window" from contextual menu

Expected results: The entire contents of the window will be printed

Actual results: A blank page

Regression - yes - this does not happen in Safari 3.1.2.  Tested with r35666 on 10.5.4 on a Mac Pro.
Comment 1 Mark Rowe (bdash) 2008-08-11 17:29:08 PDT 
<rdar://problem/6142398>
Comment 2 Gavin Sherlock 2008-08-11 23:05:48 PDT 
r31030 works, r31055 fails
Comment 3 Gavin Sherlock 2008-08-11 23:11:56 PDT 
I suspect http://trac.webkit.org/changeset/31037 though this is only an untrained eye looking at it.
Comment 4 Beth Dakin 2008-10-21 16:21:06 PDT 
Interestingly, the page prints fine if you press command-P or choose Print from the File menu. Only printing with "Print Window" through the context menu is broken.
Comment 5 Beth Dakin 2008-10-21 17:13:58 PDT 
Created attachment 24547 [details]
Reduction

Here is a reduction. I think I have a patch too. Will post shortly.
Comment 6 Beth Dakin 2008-10-21 17:21:09 PDT 
Created attachment 24548 [details]
Patch
Comment 7 Darin Adler 2008-10-21 17:21:57 PDT 
Comment on attachment 24548 [details]
Patch

r=me
Comment 8 Beth Dakin 2008-10-21 17:23:30 PDT 
Fixed with r37768.