Bug 203519 - Move tracking and computation of timer heap current insertion order to ThreadTimers
Summary: Move tracking and computation of timer heap current insertion order to Thread...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 203586
  Show dependency tree / graph
 
Reported: 2019-10-28 14:19 PDT by Daniel Bates
Modified: 2019-10-30 15:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.67 KB, patch)
2019-10-28 14:32 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-10-28 14:19:09 PDT 
We track the heap insertion count (a simple counter, which may overflow, each time an entry is inserted) as a means to ensure that timers with the same firing time are ordered by insertion in the heap. Currently this count is a process-wide (i.e. globally unique across all threads). But it doesn't need to be and it increases the rate at which the count can overflow (since multiple threads can increment it). Architecturally it makes more sense for this count to move to per-thread storage.
Comment 1 Daniel Bates 2019-10-28 14:32:00 PDT 
Created attachment 382109 [details]
Patch
Comment 2 Daniel Bates 2019-10-30 15:15:50 PDT 
Comment on attachment 382109 [details]
Patch

Clearing flags on attachment: 382109

Committed r251810: <https://trac.webkit.org/changeset/251810>
Comment 3 Daniel Bates 2019-10-30 15:15:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-10-30 15:16:29 PDT 
<rdar://problem/56760431>