Bug 203500 - Import WPT tests for scrollend and overscroll events
Summary: Import WPT tests for scrollend and overscroll events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 201556
  Show dependency treegraph
 
Reported: 2019-10-28 12:43 PDT by Frédéric Wang (:fredw)
Modified: 2019-10-30 00:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch WIP (32.94 KB, patch)
2019-10-29 02:34 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (41.46 KB, patch)
2019-10-29 04:52 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (41.26 KB, patch)
2019-10-29 14:32 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2019-10-28 12:43:11 PDT
They are located in dom/events/scrolling
Comment 1 Frédéric Wang (:fredw) 2019-10-29 02:34:43 PDT
Created attachment 382171 [details]
Patch WIP
Comment 2 Frédéric Wang (:fredw) 2019-10-29 04:52:15 PDT
Created attachment 382176 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-10-29 11:00:37 PDT
Comment on attachment 382176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382176&action=review

> LayoutTests/TestExpectations:155
> +# Only iOS has an implementation of UIScriptController::sendEventStream().

We should fix that!
Comment 4 Frédéric Wang (:fredw) 2019-10-29 11:03:12 PDT
I'm not sure what's happening with some of the bots, but I'll wait a bit before landing this.
Comment 5 WebKit Commit Bot 2019-10-29 13:14:35 PDT
Comment on attachment 382176 [details]
Patch

Rejecting attachment 382176 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 382176, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=382176&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=203500&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 382176 from bug 203500.
Fetching: https://bugs.webkit.org/attachment.cgi?id=382176
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 25 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/imported/w3c/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/TestExpectations
patching file LayoutTests/imported/w3c/resources/import-expectations.json
Hunk #1 succeeded at 108 (offset 3 lines).
Hunk #2 FAILED at 385.
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/imported/w3c/resources/import-expectations.json.rej
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-document-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-document.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-element-with-overscroll-behavior-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-element-with-overscroll-behavior.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-scrolled-element-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-scrolled-element.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-window-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-event-fired-to-window.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scroll_support.js
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-after-snap-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-after-snap.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-document-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-document.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-element-with-overscroll-behavior-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-element-with-overscroll-behavior.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-scrolled-element-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-scrolled-element.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-window-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/scrollend-event-fired-to-window.html
patching file LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/w3c-import.log
patching file LayoutTests/platform/ios/TestExpectations
Hunk #1 succeeded at 2560 (offset -2 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Simon Fraser']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13189001
Comment 6 Frédéric Wang (:fredw) 2019-10-29 14:32:13 PDT
Created attachment 382227 [details]
Patch
Comment 7 WebKit Commit Bot 2019-10-30 00:58:33 PDT
Comment on attachment 382227 [details]
Patch

Clearing flags on attachment: 382227

Committed r251770: <https://trac.webkit.org/changeset/251770>
Comment 8 WebKit Commit Bot 2019-10-30 00:58:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-10-30 00:59:17 PDT
<rdar://problem/56737022>